Skip to content

Conversation

@furqan463
Copy link
Contributor

@furqan463 furqan463 commented Sep 25, 2025

Fixes issue: #330

Changes proposed in this PR include:

  1. In "res_line_3ph" and "res_trafo_3ph", p_a_l_mw is changed to pl_a_mw, and so on for q and other phases
  2. In loads, const_z_percent, const_i_percent are replaced with const_z_p_percent, const_z_q_percent, const_i_p_percent, const_i_q_percent

Updated pandapower_converter.py

Checks

  • Need to fix unit and validation tests.
  • Need to verify ref_version after which existing code breaks.

@furqan463
Copy link
Contributor Author

furqan463 commented Sep 26, 2025

@mgovers This is working with older PP version here, and I've tested it locally with latest repo of pandapower-develop. Please review.

Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Please also update the validation test input data loader. Otherwise, it's good to go.

@mgovers
Copy link
Member

mgovers commented Sep 29, 2025

I ran the following tests:

  • create and load virtual environment
  • check that main works with original pandapower
    • git checkout main && git pull
    • editable install of main
    • install and upgrade pandapower to latest release
    • run all tests: This proves that the original main is in a good state
      • unit tests
      • validation tests
  • verify that main fails with latest pandapower
    • clone pandapower@develop
    • install cloned pandapower@develop
    • rerun all tests
      • unit tests PASS
      • validation tests FAIL!!!
        • This proves that this PR is necessary
  • verify that this branch solves the latest pandapower incompatibilities
    • checkout this PR gh pr checkout 333
    • install this PR (optional if the previous installation was as an editiable)
    • rerun all tests
      • unit tests PASS
      • validation tests PASS
        • This proves that this PR solves the issue
        • All deprecation warnings regarding pandapower are resolved: TODO
  • verify that this branch is backwards compatible
    • install latest version pandapower
    • rerun all tests
      • unit tests PASS
      • validation tests PASS
        • This proves that this PR is backwards compatible

@mgovers mgovers changed the title Fix compatibility issues with upcoming pandapower release. Pandapower converter: Fix compatibility issues with upcoming pandapower release. Sep 30, 2025
@furqan463
Copy link
Contributor Author

furqan463 commented Oct 4, 2025

@mgovers please check commit bfcb72d I noticed that pandapower converter is putting "index" column in pandapower line and trafo tables, thereby altering the input pandapower network. This commit will fix this issue as well. As this issue results in pp.nets_equal to fail while comparing copy of a network with original after running load flow with pp.runpp_pgm.

Signed-off-by: furqan463 <[email protected]>
@mgovers
Copy link
Member

mgovers commented Oct 10, 2025

FYI: pandapower released version 3.2.0 so this now has high prio. I will jump in.

@mgovers mgovers changed the base branch from main to feature/fix-nightly October 10, 2025 09:20
Signed-off-by: furqan463 <[email protected]>
@nitbharambe nitbharambe added the feature New feature or request label Oct 13, 2025
mgovers and others added 3 commits October 13, 2025 09:13
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the missing files issue @furqan463 .

I hereby approve. @nitbharambe can you please re-approve as well?

@nitbharambe nitbharambe merged commit f57f1db into PowerGridModel:feature/fix-nightly Oct 13, 2025
29 checks passed
@furqan463 furqan463 deleted the new_pp branch October 13, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants