-
Notifications
You must be signed in to change notification settings - Fork 12
Pandapower converter: Fix compatibility issues with upcoming pandapower release. #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandapower converter: Fix compatibility issues with upcoming pandapower release. #333
Conversation
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
|
@mgovers This is working with older PP version here, and I've tested it locally with latest repo of pandapower-develop. Please review. |
mgovers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Please also update the validation test input data loader. Otherwise, it's good to go.
|
I ran the following tests:
|
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: furqan463 <[email protected]>
|
@mgovers please check commit bfcb72d I noticed that pandapower converter is putting "index" column in pandapower |
Signed-off-by: furqan463 <[email protected]>
|
FYI: pandapower released version 3.2.0 so this now has high prio. I will jump in. |
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: furqan463 <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: furqan463 <[email protected]>
mgovers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the missing files issue @furqan463 .
I hereby approve. @nitbharambe can you please re-approve as well?
f57f1db
into
PowerGridModel:feature/fix-nightly
Fixes issue: #330
Changes proposed in this PR include:
Updated pandapower_converter.py
Checks