Conversation
The LimitScanner's use of a sentinel error inside an LMDB transaction aborted the transaction. I instead moved the "limit reached" marker to the cursor returned by Last().
nvaatstra
reviewed
Jan 28, 2026
wojas
previously requested changes
Jan 29, 2026
Member
wojas
left a comment
wojas
left a comment
There was a problem hiding this comment.
The new logic looks OK. The PR could have been kept more minimal with just a check for the error and assignment to a bool, but no objections to the explicit return value here, because it does make the code harder to hold wrong.
The extra locking really needs to be removed, however. LGTM if that is fixed.
Luit
force-pushed
the
fix-limited-sweeper
branch
from
0097641 to
0141333
Compare
Luit
dismissed
wojas’s stale review
Changed. Github didn't pick up on that somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LimitScanner's use of a sentinel error inside an LMDB transaction aborted the transaction. I instead moved the "limit reached" marker to the cursor returned by Last().