nix(hlint): apply hlint's suggestions inplace

[taimoorzaeem]

postgrest-lint now applies hlint's suggestions inplace to all
haskell files.

Hlint supports this via another package apply-refact which is marked broken in nixpkgs because it doesn't build with GHC 9.10, so we are using the GHC 9.12 pinned version.

[steve-chavez]

postgrest-lint now supports an optional argument --apply-hlint-suggestions which applies Hlint suggestions inplace to the input haskell file.

Very useful, I'd prefer this be the default behavior and the flag turns it off. If the lint is not applied we fail on CI anyway.

No flag is also an option.

[wolfgangwalther]

No flag is also an option.

👍

[taimoorzaeem]

No flag is also an option.

If we doing this as default, then we should also introduce the postgrest-lint-check the same way we have postgrest-style-check for postgrest-style.

[wolfgangwalther]

If we doing this as default, then we should also introduce the postgrest-lint-check the same way we have postgrest-style-check for postgrest-style.

At this point we should just introduce better tooling to handle these formatters and linters entirely. treefmt is good, with great nix integration. Will look into adding that instead to unify the interface.

[wolfgangwalther]

At this point we should just introduce better tooling to handle these formatters and linters entirely. treefmt is good, with great nix integration. Will look into adding that instead to unify the interface.

See #5200 for that.

[wolfgangwalther]

Rebased over the addition of treefmt and extended the commentary a bit.

[taimoorzaeem]

Rebased over the addition of treefmt and extended the commentary a bit.

Looks great! 👍

[postgrest-ci]

Successfully created backport PR for v16:

• v16: nix(hlint): apply hlint's suggestions inplace #5219