feat: add locally_evaluated property to $feature_flag_called#130
Closed
luke-belton wants to merge 1 commit intomasterfrom
Closed
feat: add locally_evaluated property to $feature_flag_called#130luke-belton wants to merge 1 commit intomasterfrom
locally_evaluated property to $feature_flag_called#130luke-belton wants to merge 1 commit intomasterfrom
Conversation
luke-belton
commented
Oct 30, 2025
Comment on lines
+1019
to
+1034
| lastEvent := client.GetLastCapturedEvent() | ||
| if lastEvent == nil || lastEvent.Event != "$feature_flag_called" { | ||
| t.Errorf("Expected a $feature_flag_called event, got: %v", lastEvent) | ||
| } | ||
|
|
||
| if lastEvent != nil { | ||
| if lastEvent.Properties["$feature_flag"] != "test-get-feature" { | ||
| t.Errorf("Expected feature flag key 'test-get-feature', got: %v", lastEvent.Properties["$feature_flag"]) | ||
| } | ||
| if lastEvent.Properties["$feature_flag_response"] != "variant-1" { | ||
| t.Errorf("Expected feature flag response 'variant-1', got: %v", lastEvent.Properties["$feature_flag_response"]) | ||
| } | ||
| if lastEvent.Properties["locally_evaluated"] != true { | ||
| t.Errorf("Expected locally_evaluated to be true for local evaluation, got: %v", lastEvent.Properties["locally_evaluated"]) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
my local eval tests didn't seem to be working locally, so not sure about this 🤔
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Contributor
Author
|
I can't rebase this because there are unsigned commits in the history since I raised this PR - opened #176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring this in line with other SDKs by setting a
locally_evaluatedproperty on$feature_flag_calledevents to indicate whether the flag was evaluated locally.