Fix DateTime type and function compatibility #47
+99
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve PostgreSQL datetime compatibility in wire protocol and macros: ## Wire Protocol Fixes (server/conn.go) - Fix TIME type formatting: detect date 0001-01-01 and output time only - Add duckdb.Interval handling with proper PostgreSQL format - Format intervals as "X years Y mons Z days HH:MM:SS" ## Macro Fixes (server/catalog.go) - Fix to_char: add Day, Month, Mon format codes for strftime - Fix to_date: use CASE for common date formats (strptime requires constant) - Fix to_timestamp: use CASE for common timestamp formats - Remove make_time/age macros (DuckDB has native functions) ## Transpiler Fixes (transpiler/transform/pgcatalog.go) - Remove make_time and age from custom macro list ## Test Results - Before: 622/721 subtests passing (86.3%) - After: 636/721 subtests passing (88.2%) - Improvement: +14 tests passing Remaining DateTime failure: - to_char_number: PostgreSQL number formatting not supported 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Wire Protocol Fixes (server/conn.go)
duckdb.Intervalhandling with proper PostgreSQL formatMacro Fixes (server/catalog.go)
Test Results
Remaining DateTime Failure
to_char_number: PostgreSQL number formatting not supported (to_char for numbers is a separate feature)Test plan
go test ./tests/integration/...SELECT TIME '12:30:45'SELECT INTERVAL '1 day'SELECT to_date('2024-06-15', 'YYYY-MM-DD')SELECT age(TIMESTAMP '2024-06-15', TIMESTAMP '2020-01-01')🤖 Generated with Claude Code