Skip to content

Conversation

@anth-volk
Copy link
Collaborator

Summary

  • Updates the model version alignment check script to use Modal gateway instead of GCP
  • Removes UK version checking since policyengine-uk doesn't support the older Python versions that API v1 runs on
  • Adds explanatory comments documenting why UK versions are not checked
  • Maintains backwards compatibility by accepting but ignoring the -uk flag

Test plan

  • Verified script works with US version check only
  • Confirmed script correctly ignores UK version flag
  • Tested failure case when US version doesn't exist

🤖 Generated with Claude Code

The UK package (policyengine-uk) does not support the older Python
versions that API v1 runs on, so the UK version deployed to Modal
may not match the version pinned in API v1's requirements.

This change:
- Removes UK version checking from the script
- Adds explanatory comments about why UK is not checked
- Keeps backwards compatibility by accepting but ignoring -uk flag

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (af95d34) to head (647768b).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3107   +/-   ##
=======================================
  Coverage   70.53%   70.53%           
=======================================
  Files          55       55           
  Lines        2386     2386           
  Branches      339      339           
=======================================
  Hits         1683     1683           
  Misses        642      642           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk anth-volk merged commit a6d942a into master Jan 20, 2026
7 checks passed
@anth-volk anth-volk deleted the chore/remove-deprecated-gcp-code branch January 20, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants