Skip to content

particle animation looping#3297

Open
RanPix wants to merge 5 commits into
PixelGuys:masterfrom
RanPix:particleSomething
Open

particle animation looping#3297
RanPix wants to merge 5 commits into
PixelGuys:masterfrom
RanPix:particleSomething

Conversation

@RanPix

@RanPix RanPix commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

useful for cyclical animations like leafs or butterfiles

@Wunka Wunka moved this to Easy to Review in PRs to review Jul 5, 2026
Comment thread src/particles.zig Outdated
Comment thread src/particles.zig
@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Jul 5, 2026
@RanPix

RanPix commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

done

Comment thread src/particles.zig
Comment thread src/particles.zig Outdated
@RanPix

RanPix commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

done

Comment thread src/particles.zig
typ: u16 = 0,
particleType: ParticleTypeLocal,
particleTypeLocal: ParticleTypeLocal,
particleType: ParticleType,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why does it store a copy of these rather big structs? I think this should only store the type index, the rest can be read from the array dynamically.

@RanPix RanPix force-pushed the particleSomething branch from cfd351c to c4cac11 Compare July 11, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants