fix(lending): RepaymentEvent TryFromVal E0277 — drop conflicting PartialEq derive (#597)

[albatrossxXx]

Summary

Fixes #597 — RepaymentEvent fails Val: TryFromVal (E0277), preventing the repayment event from being published.

Root cause

RepaymentEvent was decorated with both #[contracttype] and #[derive(PartialEq)]. The #[contracttype] proc-macro generates the TryFromVal<Env, Self> impl Soroban requires for env.events().publish(). Adding #[derive(PartialEq)] on a struct that contains an Address field in a #[no_std] context conflicts with the macro-generated code, causing the compiler to fail with:

error[E0277]: the trait bound `Val: TryFromVal<Env, RepaymentEvent>` is not satisfied
  --> acbu_lending_pool/src/lib.rs:619

Fix

Removed PartialEq from the #[derive(...)] on RepaymentEvent:

// Before
#[contracttype]
#[derive(Clone, Debug, PartialEq)]
pub struct RepaymentEvent { ... }

// After
#[contracttype]
#[derive(Clone, Debug)]
pub struct RepaymentEvent { ... }

This matches the established pattern for every other event struct containing an Address field in this contract (BorrowEvent, RepayEvent, LoanCreatedEvent, LoanRepaidEvent) and across the codebase (MintEvent, BurnEvent, etc. in shared/src/lib.rs).

Impact

• No logic change — only the derive attribute is modified.
• Tests in acbu_lending_pool/tests/test.rs are unaffected: they compare individual Address and i128 fields, not RepaymentEvent itself.

Acceptance criterion

acbu_lending_pool compiles without E0277. Repayment event publishes successfully.

closes #597

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 3eeb74e6-26db-449a-8b3b-49285527cf41

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[drips-wave]

@albatrossxXx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits