-
Notifications
You must be signed in to change notification settings - Fork 5
Add MacOS support #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
MacOS still needs added to the build workflow. |
|
Can/should we be building universal binaries? |
|
I added additional targets for macOS to the build action. I was going to try to get both targets to build on the Arm runner, but I was encountering a problem where the OpenCV arch got dropped if I tried to change the complier target. |
Maybe? I didn't try that yet. |
|
Building a universal binary seemed to work, which yields fewer artifacts to distribute. |
48e5f22 to
596ffc6
Compare
596ffc6 to
3515ed3
Compare
Co-authored-by: Gold856 <[email protected]>
|
It seems like OpenBLAS may not be easy to compile a universal binary for. (I haven't eliminated the possibility yet though.) |
|
Can we not link to Accelerate? |
|
Prior to macOS 26, Accelerate is 32-bit only. I only confirmed it passes the PV tests on macOS 26. |
|
To be honest, I think we use a 32 bit BLAS everywhere. I believe OpenBLAS is built with the LP64 API, so I think it's fine? And if it works with the ILP64 API, then I guess that's also fine? |
Gold856
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna block only because I want a vanilla mrcal.
This replaces
malloc.hwithstdlib.h, and adds discovery for MacOS libraries. The double*.in the library glob prevents matching thelibopencv_javabundledylibwhich cannot be loaded viafetchcontent.