Skip to content

Conversation

@thatcomputerguy0101
Copy link

This replaces malloc.h with stdlib.h, and adds discovery for MacOS libraries. The double *. in the library glob prevents matching the libopencv_java bundle dylib which cannot be loaded via fetchcontent.

@thatcomputerguy0101
Copy link
Author

MacOS still needs added to the build workflow.

@thatcomputerguy0101 thatcomputerguy0101 marked this pull request as draft November 26, 2025 21:06
@mcm001
Copy link
Collaborator

mcm001 commented Nov 26, 2025

Can/should we be building universal binaries?

@thatcomputerguy0101
Copy link
Author

I added additional targets for macOS to the build action. I was going to try to get both targets to build on the Arm runner, but I was encountering a problem where the OpenCV arch got dropped if I tried to change the complier target.

@thatcomputerguy0101
Copy link
Author

Can/should we be building universal binaries?

Maybe? I didn't try that yet.

@thatcomputerguy0101
Copy link
Author

Building a universal binary seemed to work, which yields fewer artifacts to distribute.

Co-authored-by: Gold856 <[email protected]>
@thatcomputerguy0101
Copy link
Author

It seems like OpenBLAS may not be easy to compile a universal binary for. (I haven't eliminated the possibility yet though.)

@spacey-sooty
Copy link
Member

Can we not link to Accelerate?

@thatcomputerguy0101
Copy link
Author

thatcomputerguy0101 commented Nov 29, 2025

Prior to macOS 26, Accelerate is 32-bit only. I only confirmed it passes the PV tests on macOS 26.

@Gold856
Copy link
Contributor

Gold856 commented Dec 5, 2025

To be honest, I think we use a 32 bit BLAS everywhere. I believe OpenBLAS is built with the LP64 API, so I think it's fine? And if it works with the ILP64 API, then I guess that's also fine?

Copy link
Contributor

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna block only because I want a vanilla mrcal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants