Refactor/cards - #61
Open
Bence7 wants to merge 92 commits into
Open
Conversation
- Implemented routing for the mission details page. - Created the MissionDetailsPageComponent with HTML template and styles. - Added a service to manage mission details and data retrieval. - Introduced a mapper for mission status translations and badge colors. - Developed a mock data structure for mission details. - Created a model to define the structure of mission details data. - Added unit tests for the component and service. - Updated order details page to include mission details routing. - Enhanced internationalization files with mission details translations. - Added new CSS variables for mission status colors.
…ialogs - Added mapping functions for user roles and store users in mission details page mapper. - Updated mission details page mock to include user and status information. - Modified mission details page model to incorporate user and message structures. - Enhanced mission details page service to manage user data and dialog actions based on roles. - Improved key-value component to support dynamic gaps between items. - Updated order details page mock to reflect new key-value structure with gaps. - Introduced a reusable dialog component with a corresponding spec file for testing. - Refactored input text component to conditionally display labels based on presence of label key. - Adjusted page header component layout for better responsiveness. - Added tests for the new dialog directive to ensure functionality. - Updated English and Hungarian localization files to include new dialog and role texts.
- Deleted the DeleteDialogComponent along with its HTML, TypeScript, and spec files. - Introduced DeleteMissionDialogComponent to handle mission deletion with a new structure. - Updated dialog layout to use app-page-header for better organization. - Removed ConfirmationDialogComponent and its associated files, as they were redundant. - Created an abstract dialog class to standardize dialog behavior across components. - Adjusted tests and snapshots to reflect the new dialog structure and components.
… input components' snapshots
…tyling and gap management
… intent management; enhance mission and order status handling
…omponents - Removed leading and trailing icon properties from InputNumberXVM and InputTextXVM interfaces. - Updated InputNumberComponent and InputTextComponent templates to eliminate icon rendering logic. - Cleaned up related unit tests to reflect the removal of icon functionality. - Adjusted snapshots for InputTextComponent and InputTextareaComponent to match new structure. - Enhanced CSS styles for input components to improve visual consistency and error handling.
…ve unused components and update translations
There was a problem hiding this comment.
Pull request overview
This PR represents a major refactoring effort to modernize the application's UI architecture by migrating from custom component patterns to a design system approach. The changes focus on replacing older dialog and card implementations with new standardized components.
Key Changes:
- Design System Integration: Migration from custom UI components to a design system-based approach with standardized components (ButtonComponent, FrameComponent, CardComponent, etc.)
- Dialog Refactoring: Replacement of service-based dialogs with template-driven dialogs using AbstractDialog base class
- Component Removal: Deletion of deprecated map-related form controls and associated files
- Architecture Improvement: Enhanced separation of concerns with better abstraction through base classes
Reviewed changes
Copilot reviewed 111 out of 363 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
area-data-dialog.component.* |
Refactored to extend AbstractDialog with new design system components |
areas-data-form-control.component.* |
Updated to use new dialog pattern and design system components |
order-details-page.* |
Complete overhaul using frames, badges, and standardized components |
mission-details-page.* |
New service implementation with computed signals and reactive patterns |
map-*-form-control.* |
Removed deprecated map control components |
__snapshots__/* |
Updated snapshots reflecting new component structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Is this the new record? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the style of the cards via the design system. (16 files)