fix(windows): preserve current Rust UI codegen units - #8022
Conversation
|
Warning Review limit reached
Next review available in: 4 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
left a comment
There was a problem hiding this comment.
Audited exact commit e69558b against current main. The .rcgu.o suffix is the correct discriminator for current and legacy rustc codegen-unit members while excluding lib.rmeta and ordinary bundled native objects. The sidecar-rlib fixture exercises the corrected extraction path, the host-level predicate regression passes, formatting and diff checks are clean, and the current-main merge tree is conflict-free. No blocking findings.
Summary
.rcgu.oarchive-member names when rebuilding Windows UI libraries.rlibwhose member uses the current naming shapeRoot cause
While validating the Windows event-pump fix for #6617, a real
perry/uicompile failed with undefinedperry_ui_*exports. Current rustc emits members such asperry_ui_windows-<hash>.<opaque>.<hash>.rcgu.o; the trimmer only recognized names containing literal.cgu.or-cgu., so it skipped all 16 UI objects after using their symbols to remove the staticlib copies.Validation
cargo test --profile perry-dev -p perry --bin perry coff_archive_dedup_drops_only_fully_provided_members -- --nocapturecargo test --profile perry-dev -p perry --bin perry rust_codegen_unit_recognizes_current_and_legacy_member_namescargo fmt --all -- --checkgit diff --checkperry-ui-windowsforx86_64-pc-windows-msvcperry/uiapp; the trimmer extracted 16/16 rlib CGUs and produced a 5.6 MB PENo version bump.