t/class/accessor.t - add additional :reader and :writer tests #23833
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
reviewed
Oct 11, 2025
The :reader tests are not really needed at present, as `pp_leavesub` makes the necessary copies, but exploring some fast accessor ideas which bypass that logic has shown the usefulness of having these tests present. A test for :writer on an array field already exists in a separate file. A comment pointing to that file has been added, and a test for the hash case added next to the pre-existing test.
richardleach
force-pushed
the
class_accessor-more
branch
from
b8d574d to
25e5389
Compare
tonycoz
reviewed
Oct 13, 2025
| # Reading an undefined value has predictable behaviour | ||
| $o->empty; | ||
| pass("void :reader on an uninitialized field doesn't crash"); | ||
| ok(!defined scalar $o->empty, 'scalar :reader on uninitialized field is undef'); |
There was a problem hiding this comment.
This and the similar test below should use:
is(scalar $o->empty, undef, 'scalar :reader on uninitialized field is undef');
since that will report what the define value is, if it turns out to be defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :reader tests are not really needed at present, as
pp_leavesubmakes the necessary copies, but exploring some fast accessor ideas which bypass that logic has shown the usefulness of having these tests present.The :writer tests verify that user errors are handled as expected.