Allow action after arguments #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Module::Build::Tiny requires that the action comes before the arguments. This was strictly necessary before we deprecated .modulebuildrc files at the 2013 QAH in Lancaster. I should emphasize, the Build.PL spec only specifies the [action options] order, not the [options actions] order, so Module::Build::Tiny isn't quite wrong, and if we change things here we should probably also update the spec. Alternatively, we could issue a warning if anything is left in @ARGV after argument parsing, which would suggest that argument isn't being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Module::Build::Tiny requires that the action comes before the arguments. This was strictly necessary before we deprecated
.modulebuildrcfiles at the 2013 QAH in Lancaster. This ordering isn't needed anymore, but I'm not sure if we should allow other orders too.I should emphasize, the Build.PL spec only specifies the [action options] order, not the [options actions] order, so Module::Build::Tiny isn't quite wrong, and if we change things here we should probably also update the spec.
Alternatively, we could issue a warning if anything is left in
@ARGVafter argument parsing.