Extract install path logic #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems I made a rebase error, now pushed the proper version… |
|
I like it. (I haven't reviewed the details though.) |
|
I'm seriously considering leaving out the EU::Config patch, and only applying the EU::IP patch. The former doesn't make the code as simple as one may expect because the config object is needed early in bootstraping (moving code from lib/ to inc/ instead of getting rid of it), and the latter doesn't care if it gets a MB::C or an EU::C object. It may also indirectly depend on the resolution of Perl-Toolchain-Gang/module-build-tiny#17 |
Extract install path logic to ExtUtils::InstallPaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch splits out ExtUtils::Config and ExtUtils::InstallPaths from Module::Build. That way, it enables other modules to use these pieces of logic.
This should probably not be applied until Module::Build leaves core.