Skip to content

Fix GitHub PR action and adjust AI policy#1215

Merged
NeffIsBack merged 2 commits intomainfrom
neff-fix-runner
Apr 23, 2026
Merged

Fix GitHub PR action and adjust AI policy#1215
NeffIsBack merged 2 commits intomainfrom
neff-fix-runner

Conversation

@NeffIsBack
Copy link
Copy Markdown
Member

Description

This PR should:

  1. Fix the github action that comments on PRs, but fails when the PR is from a non-maintainer
  2. Adjust the AI policy to clarify that issues and PRs are supposed to be written by humans

It looks like to comment on PRs the token needs write privileges onto PRs from this repository. Therefore, the action now has a token in the context of the Pennyw0rth/NetExec repository and not the forked repository (difference of pull_request and pull_request_target according to https://docs.github.com/de/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target). Security wise this should be fine as we operate on a fixed set of strings that can be injected into the comment. There is not much input that is controlled by the user.

I also adjusted the AI policy to more accurately reflect how I think about communication here. I don't mind when people use AI as an assistance for generating code (or content as well to some extent), but what I want to prevent is people just prompting AI and pasting the answers in Pull Requests or Issues. No one wants to communicate with a chat bot. Let me know what you think @mpgn, @Marshall-Hallenbeck.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

N/A

@NeffIsBack NeffIsBack added the documentation Improvements or additions to documentation label Apr 23, 2026
@NeffIsBack NeffIsBack requested a review from mpgn as a code owner April 23, 2026 07:30
@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Apr 23, 2026
@NeffIsBack NeffIsBack merged commit 917603b into main Apr 23, 2026
10 checks passed
@NeffIsBack NeffIsBack deleted the neff-fix-runner branch April 23, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants