Skip to content

db: do not add credential to db if guest or null auth#1133

Open
lap1nou wants to merge 1 commit intoPennyw0rth:mainfrom
lap1nou:db-guest-null
Open

db: do not add credential to db if guest or null auth#1133
lap1nou wants to merge 1 commit intoPennyw0rth:mainfrom
lap1nou:db-guest-null

Conversation

@lap1nou
Copy link
Contributor

@lap1nou lap1nou commented Mar 3, 2026

Description

Greetings,

This PR add a condition before adding a credential in the DB for the SMB protocol. Right now, when guest access is enabled, it will be added to the DB and same case for an empty username/password/hash combo.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

poetry run NetExec smb "$TARGET" -u 'dontexist' -p '' # Credential should NOT be added
poetry run NetExec smb "$TARGET" -u '' -p '' # Credential should NOT be added
poetry run NetExec smb "$TARGET" -u '$USERNAME' -p '$PASSWORD' # Credential should be added

Screenshots (if appropriate):

image image

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@lap1nou lap1nou changed the title db: do not add credential if guest or null auth db: do not add credential to db if guest or null auth Mar 3, 2026
@NeffIsBack
Copy link
Member

Thanks for the bug fix PR! Good catch

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants