Skip to content

Remove lightning tensor - #1410

Open
josephleekl wants to merge 6 commits into
mainfrom
remove-lightning-tensor
Open

Remove lightning tensor#1410
josephleekl wants to merge 6 commits into
mainfrom
remove-lightning-tensor

Conversation

@josephleekl

@josephleekl josephleekl commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Lightning tensor device is being deprecated.

[sc-123753]

josephleekl
josephleekl commented Jul 24, 2026
View reviewed changes
Comment thread .github/CHANGELOG.md Outdated
@josephleekl josephleekl added ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.21%. Comparing base (de4a947) to head (a523fa9).

Files with missing lines Patch % Lines
pennylane_lightning/lightning_base/_serialize.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   96.20%   93.21%   -3.00%     
==========================================
  Files         278      293      +15     
  Lines       40023    43531    +3508     
==========================================
+ Hits        38506    40577    +2071     
- Misses       1517     2954    +1437
Flag Coverage Δ
unit_tests 93.21% <0.00%> (-3.00%) ⬇️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josephleekl
josephleekl requested a review from a team July 24, 2026 20:41
multiphaseCFD
multiphaseCFD approved these changes Jul 24, 2026
View reviewed changes

@multiphaseCFD multiphaseCFD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephleekl
josephleekl requested a review from maliasadi July 27, 2026 15:21
maliasadi
maliasadi requested changes Jul 27, 2026
View reviewed changes

@maliasadi maliasadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our current plan for removing or deprecating features is if they carry a heavy maintenance burden or if they block any high-priority features. Why are we removing this GPU simulator now?

maliasadi
maliasadi reviewed Jul 27, 2026
View reviewed changes

@maliasadi maliasadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it offline -- there aren't any immediate applications needing this simulator. Removing this device fixes the current concerns with flaky tests + CIs. Happy to remove it! 🔥

@josephleekl
josephleekl requested a review from maliasadi July 27, 2026 20:13
maliasadi
maliasadi approved these changes Jul 31, 2026
View reviewed changes

@maliasadi maliasadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

maliasadi
maliasadi reviewed Jul 31, 2026
View reviewed changes

@maliasadi maliasadi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog before merge 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliasadi maliasadi maliasadi approved these changes
@multiphaseCFD multiphaseCFD multiphaseCFD approved these changes

Assignees

No one assigned

Labels

ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephleekl @maliasadi @multiphaseCFD @ringo-but-quantum