[DO NOT MERGE] Add lightning.amdgpu alias device for v0.43.0 - #1297
Draft
josephleekl wants to merge 26 commits into
Draft
[DO NOT MERGE] Add lightning.amdgpu alias device for v0.43.0#1297josephleekl wants to merge 26 commits into
josephleekl wants to merge 26 commits into
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v0.43.0_release #1297 +/- ##
==================================================
Coverage ? 91.34%
==================================================
Files ? 184
Lines ? 27672
Branches ? 0
==================================================
Hits ? 25276
Misses ? 2396
Partials ? 0
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
josephleekl
commented
Nov 26, 2025
josephleekl
commented
Nov 26, 2025
josephleekl
commented
Nov 26, 2025
maliasadi
reviewed
Nov 27, 2025
maliasadi
reviewed
Nov 27, 2025
maliasadi
reviewed
Nov 27, 2025
maliasadi
reviewed
Nov 27, 2025
maliasadi
left a comment
Member
There was a problem hiding this comment.
Nice work @josephleekl! Happy to have another look after updating the docs
Contributor
Author
josephleekl
commented
Nov 28, 2025
maliasadi
reviewed
Nov 28, 2025
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR introduces a new device
lightning.amdgpuas an alias forlightning.kokkosUsers can instantiate this device with
This device also works with
qjit.Notes:
lightning.kokkos, there might be issues if bothlightning.amdgpuandlightning.kokkosare installed, as there may be conflicts.pennylane_lightning_amdgpu(e.g.pennylane_lightning_amdgpu-0.43.0-cp311-cp311-linux_x86_64.whl)lightning_amdgpu_ops.cpython-311-x86_64-linux-gnu.so), but we do not change the catalyst shared lib name (liblightning_kokkos_catalyst.so), since Catalyst will continue to think this is the lightning-kokkos device.The instructions to build a wheel actually for AMD GPU is available here.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-104098]