add remote executor manager - #3082
Open
mehrdad2m wants to merge 23 commits into
Open
Conversation
Member
multiphaseCFD
marked this pull request as ready for review
August 3, 2026 16:43
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
- Coverage 96.92% 96.51% -0.42%
==========================================
Files 166 172 +6
Lines 19142 19872 +730
Branches 1815 1898 +83
==========================================
+ Hits 18553 19179 +626
- Misses 430 524 +94
- Partials 159 169 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
josephleekl
reviewed
Aug 4, 2026
Comment on lines
+132
to
+142
| def _get_backline_dispatch_address(device) -> Optional[str]: | ||
| """Dispatch address for a remote backline controller, sourced from an executor. Defaults to the controller's own ``addr:port``.""" | ||
| for ex in _get_controller_executors(device): | ||
| if _attr(ex, "address"): | ||
| return ex.address | ||
| ctrl = _get_backline_controller(device) | ||
| addr = _attr(ctrl, "addr") | ||
| if not addr: | ||
| return None | ||
| port = _attr(ctrl, "port") | ||
| return f"{addr}:{port}" if port else addr |
Contributor
There was a problem hiding this comment.
this shouldn't default to the controller's addr:port, they serve different purpose. The executor address is for orc jit dispatching, but the controller addr/port is for RDMA OOB.
Member
There was a problem hiding this comment.
@mehrdad2m what would be the recommended default value for jit dispatch?
Contributor
Author
There was a problem hiding this comment.
Thanks @josephleekl for the changes they look good on my side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new functions and code must be clearly commented and documented.
Ensure that code is properly formatted by running
make format.The latest version of black and
clang-format-20are used in CI/CD to check formatting.All new features must include a unit test.
Integration and frontend tests should be added to
frontend/test,Quantum dialect and MLIR tests should be added to
mlir/test, andRuntime tests should be added to
runtime/tests.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: