Fix/op2 as observable - #3075
Conversation
…l directly from source
There was a problem hiding this comment.
To be reverted once the fix done
There was a problem hiding this comment.
If this works then I just repalce inplace
There was a problem hiding this comment.
Does this look safe to you @paul0403 ? This PR is technically still WIP, but it seems that this file specifically blocks other work (porting Z), so I'd like to hear some early-stage feedback
|
There're bunch of |
1. It's mimicing PL Test, which requires lots of maintanence effort 2. With PL+Catalyst bound together strategy ahead, it's redundant
There was a problem hiding this comment.
I think this is needed, since we're testing catalyst.control and catalyst.adjoint rather than pennylane.control and pennylane.adjoint. Maybe I'm missing some context here though?
There was a problem hiding this comment.
Then I can cherry pick and keep catalyst.*? Also actually old frontend might be deprecated soon, but yes we still don't have a clear "what to burn" list yet.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
+ Coverage 96.92% 97.28% +0.35%
==========================================
Files 166 40 -126
Lines 19133 4935 -14198
Branches 1815 0 -1815
==========================================
- Hits 18545 4801 -13744
+ Misses 429 134 -295
+ Partials 159 0 -159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zczccz already merged Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
|
So the three template failures were covered by (at least) two different things: 1. the adjoint isse 2. the dynamic ctrl value issue |
2 participants
Context:
Not surprisingly, porting
YandCYintoOperator2introduced lots of failures. Here in this PR we aim to fix as much as possible.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-126089]