Fix for the issue with Autocomplete menu. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (foundSelected) | ||
| { | ||
| AdjustScroll(); | ||
| DoSelectedVisible(); |
Owner
There was a problem hiding this comment.
You have disabled scrolling to selected item.
Author
There was a problem hiding this comment.
Yes, those calls are redundant since both those methods are called on lines 439 and 440 (AdjustScroll() is called from _Invalidate()). Behaviour is totally same if we would uncomment lines (420-423) but those calls are unnecessary.
I've tested this and it scrolls fine to the selected item.
Collaborator
|
@tomdam Can you add back that AdjustScroll() method and verify that the fix still resolves the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue described here: #186