Italics and UI changes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bold text generation where some glyphs has weird slashes through them Those diagonal streaks came from how we read the grayscale bitmap that Win32 gives back: each glyph row is padded to a 4-byte stride, but the old loop assumed rows were laid out tightly. When the glyph width isn’t a multiple of four (Liberation Sans 18 px “p” is 11px wide), we started sampling the next row at the wrong offset, hence the slanted lines. The copy loop now computes the stride correctly, guards against under/overflow on the destination row, and uses the right slice of the buffer for each scanline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vibe coded for italics. Preview box doesn't update with italic toggle yet