Skip to content

Fix flaky proptest: accept Base32 as valid for base64 roundtrip (shor… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parv68 merged 1 commit into from
Jun 17, 2026
Merged

Fix flaky proptest: accept Base32 as valid for base64 roundtrip (shor… #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/proptest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ proptest! {
let encoded = base64::engine::general_purpose::STANDARD.encode(&data);
if !encoded.is_empty() && encoded.len() > 2 {
if let Some(result) = cryptotrace::core::encoding::detect_encoding(&encoded) {
assert_eq!(result.encoding_type, "Base64", "Base64 roundtrip of {:?} encoded as {:?}", data, encoded);
// Short base64 strings can also be valid base32, accept either
let ok = result.encoding_type == "Base64" || result.encoding_type == "Base32";
assert!(ok, "Base64 roundtrip of {:?} encoded as {:?} got {:?}", data, encoded, result.encoding_type);
}
}
}
Expand Down
Loading