Conversation
- Rewrite all if-let chains (RFC 2497) for MSRV 1.86 compatibility - Fix RocksDB API mismatches: Cache::new_lru_cache, iterator_cf with IteratorMode::From, &mut self on batch methods, &ColumnFamily clone in begin_transaction - Fix unused variable warning in query_audit - Fix all clippy warnings across tests, benches, and library code (needless_borrows_for_generic_args, match_like_matches_macro, redundant_pattern_matching, empty_line_after_doc_comments, type_complexity, too_many_arguments, bool_comparison)
- Rewrite 2 remaining if-let chains in aegis-cli (main.rs, repl.rs) - Fix 10 collapsible_else_if clippy warnings in aegis-cli repl.rs - Allow clippy::not_unsafe_ptr_arg_deref in aegis-ffi (FFI inherently takes raw pointers) - Fix rocksdb ColumnFamily: store &'static references with unsafe transmute (lifetime tied to Arc<DB> which outlives the transaction) - Fix E0502 borrow conflict in commit() by scoping the MutexGuard - Remove unused ColumnFamily import from rocksdb use statement
- Allow dead_code on intentionally unused methods/fields in rocksdb - Allow clippy::collapsible_if on patterns that would require unstable && let syntax (let_chains, RFC 2497) for MSRV 1.86 compatibility - Collapse bool-inner if-let chains where && with non-let condition - Fix needless_borrows_for_generic_args, redundant_closure, unnecessary_lazy_evaluations, unnecessary_sort_by across backends - Add clippy::too_many_arguments, clippy::type_complexity allows - Scope RwLock guards in mod.rs to avoid await_holding_lock
…gres, rocksdb, telemetry, engine
…te, fix Windows shell in security audit
…st_export_import_roundtrip bug)
…instead of continue-on-error, suppress WASM test exit code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.