-
-
Notifications
You must be signed in to change notification settings - Fork 160
Allow bulk editing of tags #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Made "target" parameter of handleAction in parts table a string Sanitize input for exisitng action which expect an int Add tag (dummy) to SelectAPI Add tag option to twig template
Hi @d-buchmann |
Indeed I got a little further, but my lack of js skills is holding me back. I can add and remove tags by entering them in the selector field by hand. The search doesn't work yet. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
============================================
- Coverage 57.77% 57.71% -0.07%
- Complexity 7043 7054 +11
============================================
Files 565 565
Lines 23028 23058 +30
============================================
+ Hits 13305 13308 +3
- Misses 9723 9750 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry, my skills are even more limited here. I only have a productive instance, so I can't easily test it. But the thing with the "ID" is interesting and fueled my curiosity. While looking into the database to understand your point I found out that it's currently easier for me to do it directly in database. So I used a SQL statement to add the tags for the parts that need it. But I still think your pull-request is useful. Thanks for your inspiration. |
This is purely theory, nothing of this is tested yet!
When implemetation is done, this should solve #178.