Skip to content

Conversation

webdevinition
Copy link

Hello @jbtronics,

In relation to #1051 the feature for custom part states.
Also mentioned in the discussion under #1041, section 3.

I am grateful for integration!

Best regards,
Marcel

@jbtronics
Copy link
Member

My preliminary remarks from a quick look at the PR:

  • What is the advantage of having the custom states as its own entity over just putting that into a tag? (Or just an additional text field in the part)?
  • The two migrations should probably be merged. I dont see much reason to have it split in two.
  • You should add tests, to ensure the admin pages are available and everything behaves like intended
  • Something has broken the existing tests.

@webdevinition
Copy link
Author

@jbtronics, please excuse me for not getting back to you on this matter yet.
It has not been forgotten, and feedback will follow in any case.

Marcel Diegelmann added 4 commits October 10, 2025 14:15
Die Sidebar wurde um die Anzeige des benutzerdefinierten Bauteilstatus erweitert, inklusive Vorschaubild, sofern vorhanden.
@webdevinition webdevinition force-pushed the feature/custom-part-status branch from e88c354 to 6cea41b Compare October 15, 2025 06:42
@webdevinition
Copy link
Author

Hello @jbtronics, thank you for your patience.

Regarding your comments:

What is the advantage of having the custom states as its own entity over just putting that into a tag? (Or just an additional text field in the part)?

In everyday use, it has proven useful to be able to use functions similar to those of the other entities, such as uploading descriptive attachments or hierarchically storing desired status types. The possibility of storing notes is also not to be overlooked. This allows the administrator to specify at the time of creation exactly when the status should be used in everyday life and why it was ultimately created.

The two migrations should probably be merged. I dont see much reason to have it split in two.

That's done.

You should add tests, to ensure the admin pages are available and everything behaves like intended

Now there are also corresponding tests which I have added analogously to other entities.

Something has broken the existing tests.

I recently made an adjustment, which may have caused the problem.

Thanks for everything so far! I've pushed the additional adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants