Prerequisite org.openrewrite.java.migrate.lang.var.UseVarFor... #11446

[Pankraz76]

Prerequisite org.openrewrite.java.migrate.lang.var.UseVarFor... hibernate#11446

[Please describe here what your change is about]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[Pankraz76]

Kindly asking if this is something to consider? @gavinking

• a couple of tiny optimizations, and use of 'var' hibernate/hibernate-orm#11446
• https://docs.openrewrite.org/recipes/java/migrate/lang/var/usevarforgenericsconstructors

I am wondering whether applying this change at scale would end up impacting performance levels in any meaningful or beneficial way, or how it actually plays out in practice.

It seems like it would align the codebase very well when applied consistently.

The use of var is also being seen in other projects, like junit:

• Enable recursive updates to NamespacedHierarchicalStore junit-team/junit-framework#5231

[gavinking]

No, we're not interested. And this is exactly the sort of pull request in which it's easy to hide a supply chain attack.

[Pankraz76]

No, we're not interested. And this is exactly the sort of pull request in which it's easy to hide a supply chain attack.

Thanks for feedback.

What you mean with attack? To sneak something in? By me or the plugin?

Its just some dome and the changes are up to you to recreate and merge in your own if needed.

This plugin and recipe and active in checkstyle and the rule covered by checkstyle as well is active in junit so idk exactly where the issue is.

Thanks for considering.

[Pankraz76]

spotless is outdated in the current state, despite the major update there are not changes. Might still be worth update and check dependabot.

• https://github.com/diffplug/spotless/blob/57436094655c28fe078bdf18bfcae8ebf5504872/rewrite.yml#L31

[Pankraz76]

kindly asking where the attack is now?

the codebase is well formatted, having achieved conventional principle.

Thanks. @gavinking