Fix path traversal in tar/zip extraction#4176
Open
AAtomical wants to merge 1 commit into
Open
Conversation
Validate archive member names before extraction to prevent directory traversal via crafted ../ entries.
|
Thanks for your contribution! |
Author
|
Fix #4175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_uncompress_file_tar()and_uncompress_file_zip()inpaddlespeech/cli/download.pyextract archive members usingtarfile.extract()/zipfile.extract()with no path validation. A crafted archive containing../entries can write files outside the intended extraction directory.This is especially relevant because dataset download URLs use plaintext HTTP (
http://www.openslr.org/,http://openslr.elda.org/), making MITM injection of malicious archives feasible.Changes
_uncompress_file_tar()and_uncompress_file_zip()..path componentsTest
Before fix: file written to
/tmp/proof.txtAfter fix:
ValueError: Path traversal detected in tar member: ../../../tmp/proof.txt