-
Notifications
You must be signed in to change notification settings - Fork 662
[BugFix] fix mm cudagraph #5266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
这个PR修复了多模态(multi-modal)模型同时启用prefix cache和CUDAGraph时出现的cuda error 700问题。通过移除之前强制禁用prefix caching的限制代码,允许这两个特性可以同时工作。
Key Changes
- 移除了在
fastdeploy/config.py中当同时启用多模态和CUDAGraph时强制禁用prefix caching的逻辑
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5266 +/- ##
==========================================
Coverage ? 59.08%
==========================================
Files ? 326
Lines ? 40321
Branches ? 6112
==========================================
Hits ? 23823
Misses ? 14653
Partials ? 1845
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
修复多模perfix cache 和 cudagraph 同时开启时,cuda error 700问题
cuda error 问题是由于多模调度方案修改,在高并发下会插入多条请求,导致显存使用比较极限,该问题在 #5181 已经修复
Modifications
Usage or Command
默认打开多模prefix caching 和 cudagraph
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.