fix: print tracebacks for per-item failures in batch generation loops - #138
Open
smcshahid wants to merge 1 commit into
Open
fix: print tracebacks for per-item failures in batch generation loops#138smcshahid wants to merge 1 commit into
smcshahid wants to merge 1 commit into
Conversation
The three batch modes (prompt_txt / image_prompt_csv / interactive_csv) wrap each item in `except Exception: continue`. A failing item currently leaves no trace: the process exits 0 with fewer (or zero) outputs after minutes of GPU time. Observed in practice: an interactive run OOM'd at postprocess after ~10 minutes and was indistinguishable from success at the process level. Keep the skip-and-continue semantics; just make the failure visible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
traceback.print_exc()before each of the three per-itemexcept Exception: continuehandlers ininfer_helios.py's batch modes (prompt_txt / image_prompt_csv / interactive_csv), plus theimport traceback.Why
A failing item currently leaves no trace: the process exits 0 with fewer (or zero) outputs after minutes of GPU time. Observed in practice: an interactive run OOM'd at the final postprocess after ~10 minutes and was indistinguishable from success at the process level —
echo $?→0, output folder empty.Compatibility / regression
🤖 Generated with Claude Code