Fix phpstan issues by making Escher generic #4690
Open
+51
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Extra checks are currently needed on the result of the
Escher::load
method, as its not clear what the return type becomes.By making this class generic, we allow to infer the return type from the constructor argument, for static analysis tools.
Additional
get...OrThrow
methods have been added, to throw more precise errors, rather than Fail due to a method call on null.