Skip to content

Its punchline time PR#104

Merged
sle3pyy merged 10 commits intodevfrom
its-punchline-time
Mar 23, 2026
Merged

Its punchline time PR#104
sle3pyy merged 10 commits intodevfrom
its-punchline-time

Conversation

@IX-0
Copy link
Copy Markdown
Contributor

@IX-0 IX-0 commented Mar 22, 2026

-> Async Tracking: Decoupled email tracking using RabbitMQ and a new background consumer.

->Public Oops Page: Transitioned the phishing educational page to a standalone Vite MPA to cleanly bypass Keycloak.

-> UI/UX Refine: Simplified the "Oops" page to be icon-focused and more skimmable.

-> Build/Deploy Fixes: Updated docker-compose files to resolve volume conflicts and standardized VITE_ variables across environments.

-> Decoupled Tests: Added a new test suite for asynchronous tracking and database consistency.

@IX-0 IX-0 requested a review from tiago-bd-oliveira March 22, 2026 20:24
@IX-0 IX-0 self-assigned this Mar 22, 2026
@IX-0 IX-0 added bug Something isn't working enhancement New feature or request labels Mar 22, 2026
@IX-0
Copy link
Copy Markdown
Contributor Author

IX-0 commented Mar 22, 2026

Needs proper testing, and resolving an issue in a test about a KEYCLOAK environment variable.

@IX-0 IX-0 marked this pull request as ready for review March 22, 2026 20:28
@IX-0 IX-0 requested a review from GabrielFcGoncalves March 22, 2026 20:28
@IX-0 IX-0 marked this pull request as draft March 22, 2026 22:16
@IX-0
Copy link
Copy Markdown
Contributor Author

IX-0 commented Mar 23, 2026

In these 3 last commits:

-> Refactored some parts of backend that still used os.getenv, logic is now in settings.py as it should

-> Optimized containerization a bit for faster deploy times.

-> Changes to frontend hardcoded colors and new color palletes for colorblind modes

@IX-0 IX-0 marked this pull request as ready for review March 23, 2026 00:59
Copy link
Copy Markdown
Member

@sle3pyy sle3pyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq raio é que meteste os links do keycloak hard coded nas setting e removeste do .env??? Por isso é q os testes falham genio

@IX-0 IX-0 marked this pull request as draft March 23, 2026 10:33
Copy link
Copy Markdown
Member

@sle3pyy sle3pyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peer programming ftw

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
48.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@IX-0 IX-0 marked this pull request as ready for review March 23, 2026 14:58
@sle3pyy sle3pyy merged commit c4f5417 into dev Mar 23, 2026
2 of 3 checks passed
@IX-0 IX-0 deleted the its-punchline-time branch March 23, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants