Skip to content
This repository was archived by the owner on Jan 25, 2026. It is now read-only.

chore: migration - #46

Closed
EncVar wants to merge 4 commits into
mainfrom
feat/eventbus
Closed

EncVar wants to merge 4 commits into
mainfrom
feat/eventbus

Conversation

@EncVar

@EncVar EncVar commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

做了一点点的迁移... (用转换器做的)

@github-actions

github-actions Bot commented Aug 24, 2025 •

Copy link
Copy Markdown

Qodana for .NET

55 new problems were found

Inspection name Severity Problems
Equality comparison of floating point numbers 🔶 Warning 8
Redundant using directive 🔶 Warning 5
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 1
Underlying type of enum is 'int' 🔶 Warning 1
Function is recursive on all execution paths 🔶 Warning 1
Redundant cast 🔶 Warning 1
Redundant name qualifier 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
String.IndexOf is culture-specific (string.IndexOf(string) is culture-specific) 🔶 Warning 1
Use preferred 'var' style (for built-in types) ◽️ Notice 12
Replace with primary constructor parameter ◽️ Notice 5
Field can be made readonly (private accessibility) ◽️ Notice 4
Use preferred style of 'new' expression when created type is evident ◽️ Notice 2
Redundant 'else' keyword ◽️ Notice 2
Use preferred 'var' style (when type is simple) ◽️ Notice 2
Adjust modifiers declaration order ◽️ Notice 1
RoslynAnalyzers Mark members as static ◽️ Notice 1
RoslynAnalyzers Use char overload ◽️ Notice 1
Join local variable declaration and assignment ◽️ Notice 1
Type check and casts can be merged ◽️ Notice 1
Merge null/pattern/value checks into 'or'/'and' patterns ◽️ Notice 1
Redundant empty argument list on object creation expression ◽️ Notice 1
Use preferred 'var' style (elsewhere) ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 27 dependencies

Third-party software list

This page lists the third-party software dependencies used in PCL.Core

Dependency Version Licenses
LiteDB 5.0.21 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.Extensions.Configuration.Abstractions 9.0.8 MIT
Microsoft.Extensions.Configuration.Binder 9.0.8 MIT
Microsoft.Extensions.Configuration 9.0.8 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 9.0.8 MIT
Microsoft.Extensions.DependencyInjection 9.0.8 MIT
Microsoft.Extensions.Diagnostics.Abstractions 9.0.8 MIT
Microsoft.Extensions.Diagnostics 9.0.8 MIT
Microsoft.Extensions.Http 9.0.8 MIT
Microsoft.Extensions.Logging.Abstractions 9.0.8 MIT
Microsoft.Extensions.Logging 9.0.8 MIT
Microsoft.Extensions.Options.ConfigurationExtensions 9.0.8 MIT
Microsoft.Extensions.Options 9.0.8 MIT
Microsoft.Extensions.Primitives 9.0.8 MIT
Microsoft.Toolkit.Uwp.Notifications 7.1.3 MIT
Polly.Core 8.6.2 BSD-3-Clause
Polly 8.6.2 BSD-3-Clause
SharpZipLib 1.4.2 MIT
System.Buffers 4.5.1 MIT
System.CodeDom 8.0.0 MIT
System.Diagnostics.DiagnosticSource 9.0.8 MIT
System.IO.Pipelines 9.0.7 MIT
System.Management 8.0.0 MIT
System.Text.Encodings.Web 9.0.7 MIT
System.Text.Json 9.0.7 MIT
System.ValueTuple 4.5.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ruattd

ruattd commented Aug 24, 2025 •

Copy link
Copy Markdown
Contributor
  • 不要把龙猫的毫无可维护性的垃圾搬进来,像是 MyColor 和 Logo
  • 龙猫的 Animation 实现完全没用任何哪怕现代一点点的方式,最好是重写掉,反正别原样搬...
  • 不要与标准库重名,不是所有人都喜欢用你的实现,你的实现也不能完全代替掉标准库,静态工具建议写成 RandomHelper 这样的名字
  • 如果你不能保证在提交之前把所有文件都检查一遍确保没被 VS 瞎几把改,就不要用 VS

@EncVar EncVar closed this Aug 27, 2025
@EncVar
EncVar deleted the feat/eventbus branch August 27, 2025 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants