This repository was archived by the owner on Jan 25, 2026. It is now read-only.
feat: 实例设置 - 服务器栏 Core 部分 - #44
Merged
Merged
Conversation
pynickle
marked this pull request as draft
August 20, 2025 10:53
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an icon management system to handle UI element icons with collection management and selection logic. The changes also include a minor bug fix for JSON parsing in the Minecraft server ping functionality.
- Added
IconModelrecord for representing icon data with name and XAML content - Implemented
IconManagerclass with collection management, selection, and XAML parsing capabilities - Fixed null reference handling in
McPing.cswhen the "players" field is missing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| UI/IconModel.cs | Defines the IconModel record structure for icon representation |
| UI/IconManager.cs | Implements the main icon management functionality with collection and selection logic |
| Link/McPing.cs | Fixes null reference exception by providing default JsonObject for missing players field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tangge233
reviewed
Aug 20, 2025
ruattd
reviewed
Aug 20, 2025
tangge233
reviewed
Aug 21, 2025
# Conflicts: # PCL.Core.csproj
pynickle
marked this pull request as ready for review
August 23, 2025 05:45
ruattd
suggested changes
Aug 28, 2025
ruattd
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link #1404