feat(app): 全新的公告系统#2786
Open
LinQingYuu wants to merge 6 commits intodevfrom
Open
Conversation
pcl-ce-automation
Bot
added
🛠️ 等待审查
审阅者指南引入了一个新的、解耦的公告系统，用于从远程服务器获取公告，根据时间和应用版本进行筛选，并以可配置的严重级别和按钮操作显示公告，同时持久化保存用户已忽略的公告。 获取和显示公告的时序图sequenceDiagram
actor User
participant AppLifecycle
participant AnnouncementService
participant HttpRequest
participant AnnouncementServer
participant MsgBoxWrapper
participant Browser
User ->> AppLifecycle: start_application
AppLifecycle ->> AnnouncementService: _Start()
loop each_source_in_AnnouncementServerList
AnnouncementService ->> HttpRequest: GetJsonAsync<List<AnnouncementDetails>>(source)
HttpRequest ->> AnnouncementServer: HTTP_GET_announcements
AnnouncementServer -->> HttpRequest: List<AnnouncementDetails>
HttpRequest -->> AnnouncementService: List<AnnouncementDetails>
AnnouncementService ->> AnnouncementService: filter_by_time_and_version
AnnouncementService ->> AnnouncementService: cleanup_invalid_ignored_ids
loop each_filtered_announcement
AnnouncementService ->> MsgBoxWrapper: ShowWithCustomButtons(details,title,theme,buttons)
MsgBoxWrapper -->> User: show_announcement_dialog
User ->> MsgBoxWrapper: click_button
MsgBoxWrapper ->> AnnouncementService: invoke_callback(operation,argument)
alt operation_is_OpenWebSite
AnnouncementService ->> Browser: Process.Start(uri)
else operation_is_StopShow
AnnouncementService ->> AnnouncementService: add_id_to_ignored
else other_operation
AnnouncementService ->> AnnouncementService: no_op
end
end
end
AppLifecycle ->> AnnouncementService: state_change_to_Closing
AnnouncementService ->> AnnouncementService: serialize_ignored_to_Config
公告系统的更新类图classDiagram
class AnnouncementService {
<<partial>>
-string[] _AllowScheme
-string[] _AnnouncementServerList
-List~string~ _ignored
+Task _Start()
-Action _GetSelectCallback(string operation, string arguments)
-MsgBoxTheme _GetSelectTheme(AnnouncementLevel level)
}
class AnnouncementDetails {
+string Title
+string Details
+int Priority
+string Id
+AnnouncementLevel Level
+string ReleaseDate
+AnnouncementSkipCondition SkipOn
+IEnumerable~AnnouncementOperation~ Buttons
}
class AnnouncementOperation {
+string ButtonText
+string Operation
+string Argument
}
class AnnouncementSkipCondition {
+string MinVersion
+string MaxVersion
+string NotAfter
+string NotBefore
}
class AnnouncementLevel {
<<enumeration>>
Lowest
Medium
Highest
}
AnnouncementService o-- AnnouncementDetails : uses
AnnouncementDetails o-- AnnouncementSkipCondition : uses
AnnouncementDetails o-- AnnouncementOperation : uses
AnnouncementDetails --> AnnouncementLevel : uses
文件级改动
提示与命令与 Sourcery 交互
自定义你的体验通过访问你的 控制面板 可以：
获取帮助Original review guide in EnglishReviewer's GuideIntroduces a new, decoupled announcement system that fetches announcements from remote servers, filters them by time and app version, and displays them with configurable severity and button actions, while persisting user-ignored announcements. Sequence diagram for fetching and displaying announcementssequenceDiagram
actor User
participant AppLifecycle
participant AnnouncementService
participant HttpRequest
participant AnnouncementServer
participant MsgBoxWrapper
participant Browser
User ->> AppLifecycle: start_application
AppLifecycle ->> AnnouncementService: _Start()
loop each_source_in_AnnouncementServerList
AnnouncementService ->> HttpRequest: GetJsonAsync<List<AnnouncementDetails>>(source)
HttpRequest ->> AnnouncementServer: HTTP_GET_announcements
AnnouncementServer -->> HttpRequest: List<AnnouncementDetails>
HttpRequest -->> AnnouncementService: List<AnnouncementDetails>
AnnouncementService ->> AnnouncementService: filter_by_time_and_version
AnnouncementService ->> AnnouncementService: cleanup_invalid_ignored_ids
loop each_filtered_announcement
AnnouncementService ->> MsgBoxWrapper: ShowWithCustomButtons(details,title,theme,buttons)
MsgBoxWrapper -->> User: show_announcement_dialog
User ->> MsgBoxWrapper: click_button
MsgBoxWrapper ->> AnnouncementService: invoke_callback(operation,argument)
alt operation_is_OpenWebSite
AnnouncementService ->> Browser: Process.Start(uri)
else operation_is_StopShow
AnnouncementService ->> AnnouncementService: add_id_to_ignored
else other_operation
AnnouncementService ->> AnnouncementService: no_op
end
end
end
AppLifecycle ->> AnnouncementService: state_change_to_Closing
AnnouncementService ->> AnnouncementService: serialize_ignored_to_Config
Updated class diagram for the announcement systemclassDiagram
class AnnouncementService {
<<partial>>
-string[] _AllowScheme
-string[] _AnnouncementServerList
-List~string~ _ignored
+Task _Start()
-Action _GetSelectCallback(string operation, string arguments)
-MsgBoxTheme _GetSelectTheme(AnnouncementLevel level)
}
class AnnouncementDetails {
+string Title
+string Details
+int Priority
+string Id
+AnnouncementLevel Level
+string ReleaseDate
+AnnouncementSkipCondition SkipOn
+IEnumerable~AnnouncementOperation~ Buttons
}
class AnnouncementOperation {
+string ButtonText
+string Operation
+string Argument
}
class AnnouncementSkipCondition {
+string MinVersion
+string MaxVersion
+string NotAfter
+string NotBefore
}
class AnnouncementLevel {
<<enumeration>>
Lowest
Medium
Highest
}
AnnouncementService o-- AnnouncementDetails : uses
AnnouncementDetails o-- AnnouncementSkipCondition : uses
AnnouncementDetails o-- AnnouncementOperation : uses
AnnouncementDetails --> AnnouncementLevel : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我发现了 3 个问题，并给出了一些总体反馈：
- 在
AnnouncementSkipCondition中，MaxVersion的 JSON 属性名是"Max"，而MinVersion是"min"；如果后端使用统一的小写命名（例如max），这会在绑定时默默失败，并可能破坏版本区间逻辑——建议将大小写与实际有效负载对齐。 AnnouncementDetails.Priority上的注释写的是“值越大优先级越高”，但查询使用的是OrderBy(a => a.Priority)，这会让值更小的优先显示；请改用OrderByDescending，或者澄清该字段的含义，以避免出现反向行为。- 版本和 URI 的解析路径（
new Version(Basics.VersionName.Split("-")[0])、new Uri(arguments)）假设数据始终有效，如果服务器返回异常值会抛出异常；建议使用Version.TryParse/Uri.TryCreate并提供优雅的降级方案，避免因为单个错误值导致整个公告流程失败。
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- 在 `AnnouncementSkipCondition` 中，`MaxVersion` 的 JSON 属性名是 `"Max"`，而 `MinVersion` 是 `"min"`；如果后端使用统一的小写命名（例如 `max`），这会在绑定时默默失败，并可能破坏版本区间逻辑——建议将大小写与实际有效负载对齐。
- `AnnouncementDetails.Priority` 上的注释写的是“值越大优先级越高”，但查询使用的是 `OrderBy(a => a.Priority)`，这会让值更小的优先显示；请改用 `OrderByDescending`，或者澄清该字段的含义，以避免出现反向行为。
- 版本和 URI 的解析路径（`new Version(Basics.VersionName.Split("-")[0])`、`new Uri(arguments)`）假设数据始终有效，如果服务器返回异常值会抛出异常；建议使用 `Version.TryParse`/`Uri.TryCreate` 并提供优雅的降级方案，避免因为单个错误值导致整个公告流程失败。
## Individual Comments
### Comment 1
<location path="PCL.Core/App/Essentials/Announcement/AnnouncementService.cs" line_range="48-57" />
<code_context>
+ var invalid = _ignored.Except(response.Select(a => a.Id)).ToList();
+ _ignored.RemoveAll(invalid.Contains);
+
+ var announcements = response.OrderBy(a => a.Priority).Where(a =>
+ {
+ var isNotAfterValid = DateTimeOffset.TryParse(a.SkipOn.NotAfter, out var notAfter);
+ var isNotBeforeValid = DateTimeOffset.TryParse(a.SkipOn.NotBefore, out var notBefore);
+ var localTime = DateTimeOffset.Now;
+ if (isNotAfterValid && localTime > notAfter) return false;
+ if (isNotBeforeValid && localTime < notBefore) return false;
+ var currentVersion = new Version(Basics.VersionName.Split("-")[0]);
+ var max = new Version(a.SkipOn.MaxVersion ?? "999.999.999");
+ var min = new Version(a.SkipOn.MinVersion ?? "0.0.0");
+
+ // [min,max]
</code_context>
<issue_to_address>
**issue (bug_risk):** 版本解析在 `MinVersion`/`MaxVersion` 包含无效或空值时可能会抛出异常。
`new Version(a.SkipOn.MaxVersion ?? "999.999.999")`（以及 `MinVersion` 的对应代码）如果服务器返回空字符串或格式错误的版本字符串，就会抛出异常。建议使用 `Version.TryParse` 并提供默认值，或者在反序列化阶段把空字符串规范化为 `null`，然后再应用这些默认值，以避免整个公告处理因为一个条目出错而中断。
</issue_to_address>
### Comment 2
<location path="PCL.Core/App/Essentials/Announcement/AnnouncementService.cs" line_range="65-68" />
<code_context>
+ });
+ foreach (var detail in announcements)
+ {
+ Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
+ detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
+ false,
+ detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
+ OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
+ }
</code_context>
<issue_to_address>
**suggestion:** 某一个公告服务器失败会中止后续服务器的处理。
因为 `foreach (var source in _AnnouncementServerList)` 循环被包裹在一个统一的 `try`/`catch (HttpRequestException)` 中，只要任意一个服务器抛出异常，就会阻止后续服务器被处理。请针对每个服务器单独处理 `HttpRequestException`（例如，在每次迭代外包一层，或者在 `GetJsonAsync` 内部捕获），以避免单个失败的端点阻塞其它端点。
建议实现方式：
```csharp
foreach (var detail in announcements)
{
Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
false,
detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
}
}
}
}
private static Action _GetSelectCallback(string operation, string arguments) => operation switch
```
要完整实现你在审查意见中建议的“按服务器分别处理错误”，可以：
1. 在该方法前面找到 `foreach (var source in _AnnouncementServerList)` 循环。
2. 将每个服务器的 HTTP 调用（例如获取该 `source` 公告的 `GetJsonAsync`/`HttpClient` 调用）包裹在各自的 `try`/`catch (HttpRequestException ex)` 块中。
3. 在每个服务器自身的 `catch` 中，使用 `Context.Error("加载公告失败", ex, ActionLevel.HintErr);`（或带上服务器/来源标识的变体）记录失败日志，然后使用 `continue;` 继续处理下一个服务器，而不是中止整个循环。
4. 移除或避免任何仍然包裹整个 `_AnnouncementServerList` 循环的外层 `try`/`catch (HttpRequestException)`，这样单个失败的端点就不会阻止后续端点被处理。
</issue_to_address>
### Comment 3
<location path="PCL.Core/App/Essentials/Announcement/Models/AnnouncementSkipCondition.cs" line_range="9-10" />
<code_context>
+{
+ [JsonPropertyName("min")]
+ public string? MinVersion { get; init; }
+ [JsonPropertyName("Max")]
+ public string? MaxVersion { get; init; }
+ [JsonPropertyName("notAfter")]
+ public string? NotAfter { get; init; }
</code_context>
<issue_to_address>
**issue (bug_risk):** `Max` 与 `min`/`notAfter`/`notBefore` 在 JSON 属性大小写上的不一致可能导致 API 不匹配。
`MaxVersion` 标注为 `[JsonPropertyName("Max")]`，而其他属性使用的是小写名称。如果实际 API 返回的是 `max`（以便与 `min`/`notAfter` 保持一致），`MaxVersion` 将会反序列化为 null。请确认预期的 JSON 大小写形式，并在需要时更新该属性（例如改为 `"max"`），以保证一致性与正确的反序列化行为。
</issue_to_address>帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进评审质量。
Original comment in English
Hey - I've found 3 issues, and left some high level feedback:
- In
AnnouncementSkipCondition, the JSON property name forMaxVersionis"Max"whileMinVersionis"min"; if the backend uses a consistent lower‑case naming (e.g.max), this will silently fail to bind and may break the version range logic—consider aligning the casing with the actual payload. - The comment on
AnnouncementDetails.Prioritysays a higher value means higher priority, but the query usesOrderBy(a => a.Priority)which will show lower values first; either switch toOrderByDescendingor clarify the meaning of the field to avoid inverted behavior. - The version and URI parsing paths (
new Version(Basics.VersionName.Split("-")[0]),new Uri(arguments)) assume always-valid data and will throw on unexpected values from the server; consider usingVersion.TryParse/Uri.TryCreatewith graceful fallback to avoid the whole announcement flow failing on a single bad value.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `AnnouncementSkipCondition`, the JSON property name for `MaxVersion` is `"Max"` while `MinVersion` is `"min"`; if the backend uses a consistent lower‑case naming (e.g. `max`), this will silently fail to bind and may break the version range logic—consider aligning the casing with the actual payload.
- The comment on `AnnouncementDetails.Priority` says a higher value means higher priority, but the query uses `OrderBy(a => a.Priority)` which will show lower values first; either switch to `OrderByDescending` or clarify the meaning of the field to avoid inverted behavior.
- The version and URI parsing paths (`new Version(Basics.VersionName.Split("-")[0])`, `new Uri(arguments)`) assume always-valid data and will throw on unexpected values from the server; consider using `Version.TryParse`/`Uri.TryCreate` with graceful fallback to avoid the whole announcement flow failing on a single bad value.
## Individual Comments
### Comment 1
<location path="PCL.Core/App/Essentials/Announcement/AnnouncementService.cs" line_range="48-57" />
<code_context>
+ var invalid = _ignored.Except(response.Select(a => a.Id)).ToList();
+ _ignored.RemoveAll(invalid.Contains);
+
+ var announcements = response.OrderBy(a => a.Priority).Where(a =>
+ {
+ var isNotAfterValid = DateTimeOffset.TryParse(a.SkipOn.NotAfter, out var notAfter);
+ var isNotBeforeValid = DateTimeOffset.TryParse(a.SkipOn.NotBefore, out var notBefore);
+ var localTime = DateTimeOffset.Now;
+ if (isNotAfterValid && localTime > notAfter) return false;
+ if (isNotBeforeValid && localTime < notBefore) return false;
+ var currentVersion = new Version(Basics.VersionName.Split("-")[0]);
+ var max = new Version(a.SkipOn.MaxVersion ?? "999.999.999");
+ var min = new Version(a.SkipOn.MinVersion ?? "0.0.0");
+
+ // [min,max]
</code_context>
<issue_to_address>
**issue (bug_risk):** Version parsing can throw if `MinVersion`/`MaxVersion` contain invalid or empty values.
`new Version(a.SkipOn.MaxVersion ?? "999.999.999")` (and the `MinVersion` equivalent) will throw if the server sends an empty or malformed version string. Consider using `Version.TryParse` with a default value, or normalizing empty strings to `null` during deserialization before applying these defaults, to avoid aborting announcement processing.
</issue_to_address>
### Comment 2
<location path="PCL.Core/App/Essentials/Announcement/AnnouncementService.cs" line_range="65-68" />
<code_context>
+ });
+ foreach (var detail in announcements)
+ {
+ Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
+ detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
+ false,
+ detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
+ OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
+ }
</code_context>
<issue_to_address>
**suggestion:** A failure on one announcement server aborts processing of subsequent servers.
Because the `foreach (var source in _AnnouncementServerList)` loop is inside a single `try`/`catch (HttpRequestException)`, an exception from any server will prevent later servers from being processed. Please handle `HttpRequestException` per server (e.g., around each iteration or inside `GetJsonAsync`) so one failing endpoint doesn’t block the rest.
Suggested implementation:
```csharp
foreach (var detail in announcements)
{
Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
false,
detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
}
}
}
}
private static Action _GetSelectCallback(string operation, string arguments) => operation switch
```
To fully implement per-server error handling as suggested in your review comment, you should:
1. Locate the `foreach (var source in _AnnouncementServerList)` loop earlier in this method.
2. Wrap the HTTP call for each server (e.g., the `GetJsonAsync`/`HttpClient` call that fetches announcements for that `source`) in its own `try`/`catch (HttpRequestException ex)` block.
3. Inside that per-server `catch`, log the failure using `Context.Error("加载公告失败", ex, ActionLevel.HintErr);` (or a variant that includes the server/source identifier) and then `continue;` to proceed to the next server instead of aborting the loop.
4. Remove or avoid any remaining outer `try`/`catch (HttpRequestException)` that wraps the entire `_AnnouncementServerList` loop, so that one failing endpoint does not prevent subsequent servers from being processed.
</issue_to_address>
### Comment 3
<location path="PCL.Core/App/Essentials/Announcement/Models/AnnouncementSkipCondition.cs" line_range="9-10" />
<code_context>
+{
+ [JsonPropertyName("min")]
+ public string? MinVersion { get; init; }
+ [JsonPropertyName("Max")]
+ public string? MaxVersion { get; init; }
+ [JsonPropertyName("notAfter")]
+ public string? NotAfter { get; init; }
</code_context>
<issue_to_address>
**issue (bug_risk):** Inconsistent JSON property casing for `Max` vs `min`/`notAfter`/`notBefore` may cause API mismatch.
`MaxVersion` is annotated with `[JsonPropertyName("Max")]` while the others use lowercase names. If the API actually returns `max` (to match `min`/`notAfter`), `MaxVersion` will deserialize as null. Please confirm the expected JSON casing and update this property (e.g., to `"max"`) if needed for consistency and correct deserialization.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+48
to
+57
| var announcements = response.OrderBy(a => a.Priority).Where(a => | ||
| { | ||
| var isNotAfterValid = DateTimeOffset.TryParse(a.SkipOn.NotAfter, out var notAfter); | ||
| var isNotBeforeValid = DateTimeOffset.TryParse(a.SkipOn.NotBefore, out var notBefore); | ||
| var localTime = DateTimeOffset.Now; | ||
| if (isNotAfterValid && localTime > notAfter) return false; | ||
| if (isNotBeforeValid && localTime < notBefore) return false; | ||
| var currentVersion = new Version(Basics.VersionName.Split("-")[0]); | ||
| var max = new Version(a.SkipOn.MaxVersion ?? "999.999.999"); | ||
| var min = new Version(a.SkipOn.MinVersion ?? "0.0.0"); |
There was a problem hiding this comment.
issue (bug_risk): 版本解析在 MinVersion/MaxVersion 包含无效或空值时可能会抛出异常。
new Version(a.SkipOn.MaxVersion ?? "999.999.999")（以及 MinVersion 的对应代码）如果服务器返回空字符串或格式错误的版本字符串，就会抛出异常。建议使用 Version.TryParse 并提供默认值，或者在反序列化阶段把空字符串规范化为 null，然后再应用这些默认值，以避免公告处理因为一个条目出错而中断。
Original comment in English
issue (bug_risk): Version parsing can throw if MinVersion/MaxVersion contain invalid or empty values.
new Version(a.SkipOn.MaxVersion ?? "999.999.999") (and the MinVersion equivalent) will throw if the server sends an empty or malformed version string. Consider using Version.TryParse with a default value, or normalizing empty strings to null during deserialization before applying these defaults, to avoid aborting announcement processing.
Comment on lines
+65
to
+68
| Context.Debug(MsgBoxWrapper.ShowWithCustomButtons( | ||
| detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level), | ||
| false, | ||
| detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText, |
There was a problem hiding this comment.
suggestion: 某一个公告服务器失败会中止后续服务器的处理。
因为 foreach (var source in _AnnouncementServerList) 循环被包裹在一个统一的 try/catch (HttpRequestException) 中，只要任意一个服务器抛出异常，就会阻止后续服务器被处理。请针对每个服务器单独处理 HttpRequestException（例如，在每次迭代外包一层，或者在 GetJsonAsync 内部捕获），以避免单个失败的端点阻塞其它端点。
建议实现方式：
foreach (var detail in announcements)
{
Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
false,
detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
}
}
}
}
private static Action _GetSelectCallback(string operation, string arguments) => operation switch要完整实现你在审查意见中建议的“按服务器分别处理错误”，可以：
- 在该方法前面找到
foreach (var source in _AnnouncementServerList)循环。 - 将每个服务器的 HTTP 调用（例如获取该
source公告的GetJsonAsync/HttpClient调用）包裹在各自的try/catch (HttpRequestException ex)块中。 - 在每个服务器自身的
catch中，使用Context.Error("加载公告失败", ex, ActionLevel.HintErr);（或带上服务器/来源标识的变体）记录失败日志，然后使用continue;继续处理下一个服务器，而不是中止整个循环。 - 移除或避免任何仍然包裹整个
_AnnouncementServerList循环的外层try/catch (HttpRequestException)，这样单个失败的端点就不会阻止后续端点被处理。
Original comment in English
suggestion: A failure on one announcement server aborts processing of subsequent servers.
Because the foreach (var source in _AnnouncementServerList) loop is inside a single try/catch (HttpRequestException), an exception from any server will prevent later servers from being processed. Please handle HttpRequestException per server (e.g., around each iteration or inside GetJsonAsync) so one failing endpoint doesn’t block the rest.
Suggested implementation:
foreach (var detail in announcements)
{
Context.Debug(MsgBoxWrapper.ShowWithCustomButtons(
detail.Details, $"{detail.Title} ({detail.ReleaseDate})", _GetSelectTheme(detail.Level),
false,
detail.Buttons.Select(operation => new MsgBoxButtonInfo(operation.ButtonText,
OnClick: _GetSelectCallback(operation.Operation, operation.Argument))).ToArray()).ToString());
}
}
}
}
private static Action _GetSelectCallback(string operation, string arguments) => operation switchTo fully implement per-server error handling as suggested in your review comment, you should:
- Locate the
foreach (var source in _AnnouncementServerList)loop earlier in this method. - Wrap the HTTP call for each server (e.g., the
GetJsonAsync/HttpClientcall that fetches announcements for thatsource) in its owntry/catch (HttpRequestException ex)block. - Inside that per-server
catch, log the failure usingContext.Error("加载公告失败", ex, ActionLevel.HintErr);(or a variant that includes the server/source identifier) and thencontinue;to proceed to the next server instead of aborting the loop. - Remove or avoid any remaining outer
try/catch (HttpRequestException)that wraps the entire_AnnouncementServerListloop, so that one failing endpoint does not prevent subsequent servers from being processed.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
重做了整套公告系统，使其和更新服务解耦
并且扩展支持了按时间和版本进行展示
目前可能还需要修一点 bug，以及配套设施还没落地
Summary by Sourcery
引入一个专用的公告服务，用于根据时间和版本约束获取并展示远程公告，并与更新系统解耦。
新功能：
增强内容：
Original summary in English
Summary by Sourcery
Introduce a dedicated announcement service that fetches and displays remote announcements based on time and version constraints, decoupled from the update system.
New Features:
Enhancements: