-
Notifications
You must be signed in to change notification settings - Fork 80
Add NettyRestConf Tests #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add NettyRestConf Tests #2402
Conversation
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing capabilities for the Netty-based RestConf component. It introduces a dedicated configuration class and refactors existing configuration handling to align with this new structure. The core of the PR lies in the addition of a comprehensive test suite, which includes a base class for setting up the test environment, unit tests for the new configuration, and integration tests for functionalities like YANG Patch, ensuring the Netty RestConf operates as expected and is well-verified. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces tests for NettyRestConf and refactors the configuration to use a dedicated NettyRestConfConfiguration class. The changes are well-implemented, and the new tests provide valuable verification for configuration loading and basic functionality. I've identified a couple of minor issues, including some duplicated code and misleading log messages, and have provided suggestions for improvement. Overall, this is a solid enhancement to the codebase.
...y/modules/northbound/netty/restconf/community/impl/tests/NettyRestConfConfigurationTest.java
Outdated
Show resolved
Hide resolved
.../io/lighty/modules/northbound/netty/restconf/community/impl/tests/NettyRestConfTestBase.java
Outdated
Show resolved
Hide resolved
d307d6c to
ad033e9
Compare
ad033e9 to
2242d7e
Compare
Add tests based of CommunityRestConf tests to properly verify netty restconf and its configuration. JIRA: LIGHTY-333 Signed-off-by: tobias.pobocik <[email protected]> Signed-off-by: Ivan Hrasko <[email protected]>
2242d7e to
3e908ae
Compare
Add tests based of CommunityRestConf tests to properly verify netty restconf
and its configuration.
JIRA: LIGHTY-333