Skip to content

Conversation

@Tobianas
Copy link
Contributor

Add tests based of CommunityRestConf tests to properly verify netty restconf
and its configuration.

JIRA: LIGHTY-333

@gemini-code-assist
Copy link

Summary of Changes

Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the testing capabilities for the Netty-based RestConf component. It introduces a dedicated configuration class and refactors existing configuration handling to align with this new structure. The core of the PR lies in the addition of a comprehensive test suite, which includes a base class for setting up the test environment, unit tests for the new configuration, and integration tests for functionalities like YANG Patch, ensuring the Netty RestConf operates as expected and is well-verified.

Highlights

  • NettyRestConf Configuration: A new NettyRestConfConfiguration class has been introduced to specifically manage the configuration parameters for the Netty-based RestConf implementation.
  • Configuration Refactoring: Existing code has been updated to utilize the new NettyRestConfConfiguration and its associated utility methods for loading and managing RestConf settings, replacing the generic RestConfConfiguration.
  • Comprehensive Test Suite: A new set of tests has been added, including a base test class for environment setup, unit tests for the new configuration, and integration tests for functionalities like YANG Patch operations, ensuring the robustness of Netty RestConf.
  • Dependency Management: The pom.xml file was updated to include necessary test dependencies and other modules required for the new testing framework and configuration, such as restconf-server-api-testlib.
  • Resource Cleanup: A minor but important change was made to ensure the yangLibraryWriter is properly closed during the LightyController shutdown, preventing potential resource leaks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tests for NettyRestConf and refactors the configuration to use a dedicated NettyRestConfConfiguration class. The changes are well-implemented, and the new tests provide valuable verification for configuration loading and basic functionality. I've identified a couple of minor issues, including some duplicated code and misleading log messages, and have provided suggestions for improvement. Overall, this is a solid enhancement to the codebase.

@Tobianas Tobianas force-pushed the netty-config-tests branch 2 times, most recently from d307d6c to ad033e9 Compare October 15, 2025 16:35
@ihrasko ihrasko self-requested a review October 21, 2025 13:41
@ihrasko ihrasko force-pushed the netty-config-tests branch from ad033e9 to 2242d7e Compare October 21, 2025 13:56
Add tests based of CommunityRestConf tests to properly verify netty
restconf and its configuration.

JIRA: LIGHTY-333
Signed-off-by: tobias.pobocik <[email protected]>
Signed-off-by: Ivan Hrasko <[email protected]>
@ihrasko ihrasko force-pushed the netty-config-tests branch from 2242d7e to 3e908ae Compare October 21, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants