Fix cgi scope reference in CLI (boxlang) environments#184
Open
michaelborn wants to merge 1 commit intoOrtus-Solutions:developmentfrom
Open
Fix cgi scope reference in CLI (boxlang) environments#184michaelborn wants to merge 1 commit intoOrtus-Solutions:developmentfrom
michaelborn wants to merge 1 commit intoOrtus-Solutions:developmentfrom
Conversation
When running testbox on boxlang CLI, no `cgi` scope exists. Thus we need to fall back to an empty string for the `hostname` junit attribute.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where TestBox's JUnit reporters would fail in BoxLang CLI environments because the cgi scope does not exist in non-web contexts. The fix uses the null coalescing operator to gracefully fall back to an empty string for the hostname attribute in XML output.
Changes:
- Added defensive null coalescing for
cgi.remote_hostaccess in both JUnit XML reporters - Ensures reporters work correctly in both web and CLI execution contexts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| system/reports/JUnitReporter.cfc | Added null coalescing operator to safely access cgi.remote_host, defaulting to empty string when CGI scope is unavailable |
| system/reports/ANTJUnitReporter.cfc | Added null coalescing operator to safely access cgi.remote_host, defaulting to empty string when CGI scope is unavailable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running testbox on boxlang CLI, no
cgiscope exists. Thus we need to fall back to an empty string for thehostnamejunit attribute.Description
Please include a summary of the changes and which issue(s) is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please note that all PRs must have tests attached to them
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Jira Issues
TESTBOX-429
Type of change
Please delete options that are not relevant.