Ensure that BOOLEANS are TRUE|FALSE and not 0|1#630
Open
gavinbaumanis wants to merge 3 commits intoOrtus-Solutions:developmentfrom
Open
Ensure that BOOLEANS are TRUE|FALSE and not 0|1#630gavinbaumanis wants to merge 3 commits intoOrtus-Solutions:developmentfrom
gavinbaumanis wants to merge 3 commits intoOrtus-Solutions:developmentfrom
Conversation
Contributor
|
This looks good. However, we need to test against MySQL and the other databases. |
Author
|
Hi Luis - thanks for the reply...
Message ID: ***@***.***>
I am happy to test with other DBs but cannot at the moment - because of the
true|false booleans getting stringified.
Eg: false -> "false"
Here is the first of many errors I get from running the migrations
[image: image.png]
|
Contributor
|
hi @gavinbaumanis we will be back 100% on things next week. Sorry for the delays, but the release of BoxLang and ITB really consumed our time. Hopefully, we can start closing a lot of these tickets soon. FYI, your image did not come through? |
Author
|
Hi @lmajano |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Postgresql does not auto cast a 0|1 value to FALSE|TRUE - for Boolean types.
This PR changes 0|1 values -> FALSE|TRUE
Jira Issues
Type of change
Please delete options that are not relevant.
Checklist
My changes are correct but still fail because QB is "string-ifying" my boolean values from
falseto"false".Nonetheless - Here is my PR - once QB is corrected - this PR will be appropriate.