Conversation
…tion-guard [feature] clamp publish min replications to on-chain minimum
8.2.5 Prerelease Testnet
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| [], | ||
| CONTRACTS.PARAMETERS_STORAGE, | ||
| ); | ||
| } |
There was a problem hiding this comment.
On-chain minimum never applied on EVM
Medium Severity
getMinimumRequiredSignatures returns the raw contract value from web3-service.js, so Number(chainMin) in publish-http-api-controller-v1.js can fail for ethers BigNumber. The error is swallowed, and minimumNumberOfNodeReplications falls back to user/default values instead of the on-chain minimum.


Note
Medium Risk
Changes the publish replication parameter resolution and adds a new on-chain contract read, which can affect publish behavior and introduces a new runtime dependency on blockchain calls (with a logged fallback on failure).
Overview
Bumps the node version from
8.2.4to8.2.5.Updates the v1 publish HTTP endpoint to resolve
minimumNumberOfNodeReplicationsby combining (1) the request value (orPUBLISH_MIN_NUM_OF_NODE_REPLICATIONSfallback) with (2) the on-chainminimumRequiredSignatures(taking the max), and wires this through via a newblockchainModuleManager.getMinimumRequiredSignatures()call.Adds the blockchain/web3 plumbing to read
minimumRequiredSignaturesfromParametersStorage, plus new unit tests asserting clamping/override/fallback behavior for publish commands.Written by Cursor Bugbot for commit 5e97684. This will update automatically on new commits. Configure here.