fix: overflowing autofill background color in inputs - #3811
Merged
vprothais merged 4 commits intoSep 14, 2026
Merged
Conversation
3 tasks
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
louismaximepiton
left a comment
Member
There was a problem hiding this comment.
Looks good to me, not sure we should do it for Select for now
louismaximepiton
approved these changes
Sep 14, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The .icon padding selector is missing, so autofill backgrounds can still cover leading icons.
Pull request overview
Fixes autofill backgrounds overlapping leading icons in text inputs.
Changes:
- Applies
background-clip: content-boxto text fields and textareas. - Updates generated CSS snapshots.
File summaries
| File | Description |
|---|---|
scss/tests/snapshot-tests/__snapshots__/ouds-web.css |
Updates the standard CSS snapshot. |
scss/tests/snapshot-tests/__snapshots__/ouds-web-bootstrap.css |
Updates the Bootstrap-compatible CSS snapshot. |
scss/forms/_text-input.scss |
Adds autofill background clipping. |
Review details
Files not reviewed (2)
- scss/tests/snapshot-tests/snapshots/ouds-web-bootstrap.css: Generated file
- scss/tests/snapshot-tests/snapshots/ouds-web.css: Generated file
Suppressed comments (1)
scss/forms/_text-input.scss:112
- This only prevents the autofill background from covering icons when the leading icon is an
svg/img, because the padding rule below (lines 292-299) does not include the supported> .iconvariant. For a leading.icon, the field keepspadding: 0, sobackground-clip: content-boxis effectively the same asborder-boxand the autofill background still covers the icon; include.iconin that padding selector as part of this fix.
background-clip: content-box; // fixes https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/issues/3809
- Files reviewed: 1/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vprothais
approved these changes
Sep 14, 2026
vprothais
deleted the
main-ml-autofilled-input-overlapping-leading-icon
branch
September 14, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Related issues
Closes #3809
Context & Motivation
Fixes a bug where the autofill background was bleeding over the leading icon of inputs
Description
Add
background-clip: content-boxso the background is not shown on the paddings but still visible (suggestion wasbackground-clip: text` which would have hidden the fact that the field is autofilled to the user)
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
mainfollowing conventional commitLive previews