Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hannahiss
marked this pull request as ready for review
September 8, 2026 16:04
# Conflicts: # site/data/sidebar-components.yml
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several links and the legacy redirect are broken, and the documented attribute cleanup remains incomplete.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Splits icon guidance between Foundation and Utilities documentation.
Changes:
- Adds Foundation icon usage, accessibility, and color guidance.
- Retains icon sizing guidance under Utilities.
- Updates navigation and cross-references.
File summaries
| File | Description |
|---|---|
site/src/scss/_component-examples.scss |
Makes the mask icon inherit sizing. |
site/src/content/docs/utilities/text.mdx |
Updates the sizing link. |
site/src/content/docs/utilities/icons-sizing.mdx |
Focuses the page on sizing utilities. |
site/src/content/docs/utilities/color.mdx |
Updates icon color links. |
site/src/content/docs/getting-started/migration.mdx |
Updates migration links. |
site/src/content/docs/getting-started/migration-from-boosted.mdx |
Updates migration links. |
site/src/content/docs/foundation/typography.mdx |
Updates sizing links. |
site/src/content/docs/foundation/icons.mdx |
Adds the Foundation icon guide. |
site/src/content/docs/components/links.mdx |
Updates accessibility guidance link. |
site/src/content/docs/components/buttons.mdx |
Updates accessibility guidance links. |
site/src/content/callouts/info-icons-svg-sprite.md |
Updates the icon usage link. |
site/data/sidebar-utilities.yml |
Adds Icons sizing navigation. |
site/data/sidebar-foundation.yml |
Adds Icons navigation. |
site/data/sidebar-components.yml |
Removes the old Icon entry. |
Review details
Suppressed comments (3)
site/src/content/docs/utilities/icons-sizing.mdx:390
- After moving accessibility guidance to the Foundation page, the paragraph below still links to the now-absent local
#icons-accessibilityfragment. Point it to the new page so this guidance remains reachable.
site/src/content/docs/utilities/icons-sizing.mdx:63 - The promised attribute cleanup is incomplete: examples throughout this sizing page (lines 129–525) still contain 45
width,height, andfillattribute sets, although their utility classes already provide those properties through%icon-size. This contradicts the PR description and leaves redundant attributes in copied examples; remove them across the remaining examples.
site/src/content/docs/utilities/icons-sizing.mdx:530 - Use “experience any trouble” rather than “experimenting any trouble,” and capitalize the product name as “GitHub.”
- Files reviewed: 14/14 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
louismaximepiton
self-requested a review
September 10, 2026 11:52
louismaximepiton
requested changes
Sep 10, 2026
louismaximepiton
left a comment
Member
There was a problem hiding this comment.
Few things, let me know if there is any issue in here
louismaximepiton
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #3792
Description
Split the page in two, and make room inside the component section for the incoming page "Icons" containing icon component:
width,heightandfillattributes and replace with utility sizing icon classesChecklists
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews