fix(docs): Update aria-describedby in text-area - #3757
Open
louismaximepiton wants to merge 2 commits into
Open
louismaximepiton wants to merge 2 commits into
louismaximepiton wants to merge 2 commits into
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vprothais
requested changes
Aug 18, 2026
vprothais
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure if the good version is the Text Input one or the Text Area one actually. When there is an helper text plus an helper link, we don't add the link to the aria attribute.
I couldn't find any message explaining the strategy regarding the link.
Maybe @nilloq have some memories about this part ?
In any case, when the strategy is clear, we should add an explaination in the documentation about it. The fact that the link should be linked only when there is no helper text should be more explicit.
ping @MewenLeHo
Member
Author
|
On a call with Mewen, we agreed that :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #3756
Description
Read #3756
Checklists
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews