feat(app, components): wire up robot out of storage modal in ODD - #22082
Open
ncdiehl11 wants to merge 1 commit into
Open
feat(app, components): wire up robot out of storage modal in ODD#22082ncdiehl11 wants to merge 1 commit into
ncdiehl11 wants to merge 1 commit into
Conversation
Creates ODD variant of RobotOutOfStorage modal and wires into call to action from ODD ProtocolDetails page. Also makes minor style change to StorageBar shared component, and delets duplicate hook. Closes EXEC-2886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Creates ODD variant of RobotOutOfStorage modal and wires into call to action from ODD ProtocolDetails page. Also makes minor style change to StorageBar shared component, and delets duplicate hook.
Closes EXEC-2886
Test Plan and Hands on Testing
Mock full robot storage on a dev ODD by early returning true in
app/src/resources/devices/hooks/useIsRobotOutOfStorage.tsChangelog
RobotOutOfStorageModalProtocolDetailsuseIsRobotOutOfMemoryhookStorageBarshared componentReview requests
see test plan
Risk assessment
⬇️