feat(audit-server): build server-side logic for log period deletion keys - #22068
feat(audit-server): build server-side logic for log period deletion keys#22068ncdiehl11 wants to merge 2 commits into
Conversation
Introduces audit-server-side logic for creating and persisting unqiue deletion keys for each
successful log download request at /audit/external/logPeriods/${logPeriodId}/download. Adds required
alembic migration for new DeletionKey table. Keeps the releationship between deletion key and
associated recoord generic to support requiring deletion keys for other record types in the future.
Closes EXEC-2878
sfoster1
left a comment
There was a problem hiding this comment.
i don't think the deletion key needs to go in the database at all, honestly. the reason this exists is to provide a "hey wait!" warning flag if somebody writes a client that just deletes stuff without thinking about it, and for that purpose having them live in memory (with some limit - one per period, even) is totally fine. there's no need for them to survive reboots.
So do you propose this logic lives purely in Redux state? The flow in this case would be:
|
…interface for key maintenance rather than creating a separate top-level deletion keys store
Overview
Introduces audit-server-side logic for creating and storing unique deletion keys for each successful log download request at
/audit/external/logPeriods/${logPeriodId}/download. Deletion keys do not survive server restarts.Closes EXEC-2878
Test Plan and Hands on Testing
Changelog
Review requests
Please inspect code and unit tests.
Risk assessment
low