Midnight v1 – 03 Auto Simple View Rendering

[pasevin]

Midnight Adapter: Auto Simple View Rendering

Overview

This PR implements Phase 5 (US3): Auto Simple View Rendering for the Midnight adapter, completing the core functionality for automatically rendering and querying read-only contract functions in the UI Builder.

Key Features

✅ View Function Validation

• Early detection of view functions via isMidnightViewFunction() check
• Defense-in-depth validation in queryMidnightViewFunction() handler
• Proper separation of read-only vs state-modifying functions

✅ Query Execution

• Dynamic loading of contract ledger() function from compiled module
• Contract state querying via Midnight indexer
• Support for both parameter-less and parameterized view functions

✅ Output Formatting

• Consistent formatting of diverse result types
• Primitives (numbers, strings, booleans) display without JSON quotes
• BigInt values handled correctly
• Null/undefined and complex types (arrays, objects) properly formatted

✅ Configuration Management

• getWalletConfigIfAvailable() relocated to src/configuration/provider.ts
• RPC endpoint precedence: user override > wallet config > network defaults
• Privacy-respecting integration with Midnight Wallet

✅ Comprehensive Testing

• 56 unit tests covering all Phase 5 requirements
• View function validation tests
• Query handler input validation
• Output formatter edge cases and error handling

Technical Highlights

Browser Compatibility

• Extended pnpm patches for Node.js-specific dependencies
• Vite configuration with WASM and CommonJS-to-ESM support
• Removed unnecessary polyfills from index.html

Module Resolution

• Global NetworkId override for module singleton workaround
• Dynamic contract module loading with new Function()
• Proper error handling for version mismatches

Validation Strategy

• Strict address validation (bech32m format for users, hex prefix for contracts)
• Early schema validation to catch issues before execution
• Comprehensive error messages for debugging

Files Changed

New Files

• src/configuration/provider.ts - Wallet configuration retrieval
• src/validation/address.ts - Address validation logic
• src/validation/index.ts - Validation module barrel
• src/query/__tests__/view-checker.test.ts - View function tests (12 tests)
• src/query/__tests__/handler.test.ts - Handler validation tests (8 tests)
• src/transform/__tests__/output-formatter.test.ts - Output formatting tests (36 tests)

Modified Files

• src/adapter.ts - Updated to pass contract module to query handler
• src/query/handler.ts - Implemented complete query orchestration with provider setup
• src/query/executor.ts - Added ledger function dynamic loading
• src/transform/output-formatter.ts - Centralized result formatting logic
• src/networks/testnet.ts - Added networkId configuration
• src/utils/index.ts - Removed address validation exports
• src/query/index.ts - Made executor/provider internal
• tsup.config.ts - External WASM packages configuration
• packages/types/src/networks/config.ts - Extended MidnightNetworkConfig type

Deleted Files

• src/query/provider.ts - Logic moved to handler
• src/utils/address-validation.ts - Moved to validation/address.ts
• src/utils/__tests__/address-validation.test.ts - Moved to validation tests

Testing

All 56 tests pass:

✓ view-checker.test.ts (12 tests)
✓ handler.test.ts (8 tests)
✓ output-formatter.test.ts (36 tests)

Test Files  3 passed (3)
Tests  56 passed (56)

Commits

• ad54ceea - test(adapter-midnight): add comprehensive Phase 5 unit tests for view functions
• f0fe2a9b - chore(deps): update pnpm lock file
• 6e313ad7 - feat(adapter-midnight): consolidate provider config and add view function validation
• 470202db - fix(adapter-midnight): add pnpm patches for Midnight SDK browser compatibility

Related Issues

Closes #4 (Add Midnight Adapter)

Migration Notes

No breaking changes for consumers. The Phase 4 foundation is fully compatible with Phase 5 additions.

Next Steps

• Phase 6: Write transaction support (transaction construction and signing)
• Integration testing with live Midnight testnet
• Performance optimization for large contract schemas

[Copilot]

Copilot reviewed 48 out of 49 changed files in this pull request and generated 7 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 48 out of 49 changed files in this pull request and generated 9 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}