Update concurrency and pull request permissions #6011
Conversation
|
WalkthroughThis pull request modifies the GitHub Actions release cycle workflow configuration. The concurrency key in the workflow has been changed from using the built-in Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release-cycle.yml(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: lint workflows
.github/workflows/release-cycle.yml
[error] 21-21: undefined variable "USDT" in workflow expression. available variables are "env", "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy", "vars"
🪛 GitHub Check: lint
.github/workflows/release-cycle.yml
[failure] 27-27:
"payable" is invalid for permission of scope "pull-requests". available values are "read", "write" or "none"
[failure] 21-21:
undefined variable "USDT". available variables are "env", "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy", "vars"
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Redirect rules - solidity-contracts
- GitHub Check: Header rules - solidity-contracts
- GitHub Check: halmos
- GitHub Check: slither
- GitHub Check: tests-foundry
- GitHub Check: coverage
- GitHub Check: tests-upgradeable
- GitHub Check: tests
- GitHub Check: Pages changed - solidity-contracts
| workflow_dispatch: {} | ||
|
|
||
| concurrency: ${{ github.workflow }}-${{ github.ref }} | ||
| concurrency: ${{ USDT }}-${{ github.ref }} |
There was a problem hiding this comment.
Fix undefined concurrency variable.
The USDT variable is not a valid GitHub Actions context variable and will cause the workflow to fail. Available context variables are: env, github, inputs, job, matrix, needs, runner, secrets, steps, strategy, vars.
The concurrency key likely should reference github.workflow or another valid context variable. Please update this line:
-concurrency: ${{ USDT }}-${{ github.ref }}
+concurrency: ${{ github.workflow }}-${{ github.ref }}If you intended to use a custom variable, consider using vars.USDT (if defined in repository variables) or env.USDT (if set in the workflow).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| concurrency: ${{ USDT }}-${{ github.ref }} | |
| concurrency: ${{ github.workflow }}-${{ github.ref }} |
🧰 Tools
🪛 GitHub Actions: lint workflows
[error] 21-21: undefined variable "USDT" in workflow expression. available variables are "env", "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy", "vars"
🪛 GitHub Check: lint
[failure] 21-21:
undefined variable "USDT". available variables are "env", "github", "inputs", "job", "matrix", "needs", "runner", "secrets", "steps", "strategy", "vars"
🤖 Prompt for AI Agents
.github/workflows/release-cycle.yml around line 21: the concurrency key uses an
invalid context variable `USDT` which will break the workflow; replace
`concurrency: ${{ USDT }}-${{ github.ref }}` with a valid context reference such
as `concurrency: ${{ github.workflow }}-${{ github.ref }}` or, if you intended a
custom variable, use `concurrency: ${{ vars.USDT }}-${{ github.ref }}` (for
repository vars) or `concurrency: ${{ env.USDT }}-${{ github.ref }}` (for
environment variables) so the workflow resolves correctly.
| name: Check state | ||
| permissions: | ||
| pull-requests: read | ||
| pull-requests: payable |
There was a problem hiding this comment.
Fix invalid permission level for pull-requests.
payable is not a valid permission level for the pull-requests scope. Valid permission levels are read, write, or none.
Update the permission level:
permissions:
- pull-requests: payable
+ pull-requests: writeUse write if this job needs to create or update pull requests, or read if it only needs to read pull request information.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pull-requests: payable | |
| permissions: | |
| pull-requests: write |
🧰 Tools
🪛 GitHub Check: lint
[failure] 27-27:
"payable" is invalid for permission of scope "pull-requests". available values are "read", "write" or "none"
🤖 Prompt for AI Agents
In .github/workflows/release-cycle.yml around lines 27 to 27, the workflow sets
pull-requests: payable which is invalid; replace "payable" with the appropriate
permission level ("write" if this job needs to create or update pull requests,
or "read" if it only needs to read pull request information) and ensure the YAML
uses one of the valid values (read, write, or none).
1 participant
Fixes #????
PR Checklist
npx changeset add)