Skip to content

feat: Run Scanner in a Separate Tokio Task #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Run Scanner in a Separate Tokio Task #138

wants to merge 6 commits into from

Conversation

@0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Oct 23, 2025

  • avoids forcing lib users to manually wrap scanners in tokio tasks
  • better error bubbling DevEx
  • fixes flaky tests <- used to fail due to race conditions; with this PR, scanner logic becomes more deterministic

Additional changes:

  • remove redundant code
  • add additional macro helpers for stream assertions
  • test refactors <- use macro helpers

@0xNeshi 0xNeshi self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeoPatOZ LeoPatOZ Awaiting requested review from LeoPatOZ LeoPatOZ is a code owner

@pepebndc pepebndc Awaiting requested review from pepebndc pepebndc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@0xNeshi 0xNeshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@0xNeshi