fix: prevent nested folders from receiving special icons.#561
fix: prevent nested folders from receiving special icons.#561MakinoharaShoko merged 1 commit intoOpenWebGAL:devfrom
Conversation
Only folders directly under the root should get special folder icons (e.g., folder-images, folder-audio). Previously, a path like "scene/figure/video/" would also match the mapping because its base name "video" is in the mapping list, leading to incorrect icons. This change adds `hasSpecialParent` to check whether any ancestor directory is a known special folder. If so, the folder is treated as unknown and falls back to the default folder icon.
Summary of ChangesHello @fltLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决一个问题,即嵌套在特殊目录下的文件夹(例如 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
fix: #525
为嵌套在特殊目录下, 拥有特殊名称的文件夹 (例如
scene/figure) 赋予特殊图标是无意义的.这么做容易引起混淆, 而且其下的资源也无法使用