Skip to content

fix: newsletter-banner-color#985

Open
BarbaraOliveira13 wants to merge 5 commits into
rc-4.0.0from
fix/newsletter-banner-color
Open

fix: newsletter-banner-color#985
BarbaraOliveira13 wants to merge 5 commits into
rc-4.0.0from
fix/newsletter-banner-color

Conversation

@BarbaraOliveira13
Copy link
Copy Markdown
Collaborator

@BarbaraOliveira13 BarbaraOliveira13 commented May 11, 2026

🎩 Description

Backport of the newsletter banner color fix from #954 (branch alt/cd44) to rc-4.0.0.

Instead of hardcoding the white color, this PR introduces an environment variable DECIDIM_CUSTOM_NEWSLETTER_BAR_COLOR to configure the banner color per client. If the variable is not set, the default Decidim behavior is preserved — no other clients are impacted.

The variable must be set to #FFFFFF for Loire Atlantique/cd44 after merging.

Also, fix Accessibilty test spec/system/proposals_index_spec.rb[1:1:2:2] by override .rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/decidim-a664bb881843/decidim-core/app/cells/decidim/data_consent/category.erb app/cells/decidim/data_consent/category.erb and changing h3 -> span Line 16

Testing

  • Set DECIDIM_CUSTOM_NEWSLETTER_BAR_COLOR="#FFFFFF" in your .env or when you're run 'DECIDIM_CUSTOM_NEWSLETTER_BAR_COLOR=#FFFFFF bundle exec rails s'
  • Send a test newsletter from the admin panel
  • Check that the banner background color is white
  • Remove the variable and verify the banner returns to its default color

📌 Related Issues

Tasks

  • Add specs
  • In case of new dependencies or version bump, update related documentation

🛠️ If your PR introduces or updates an Override

  • Add the label "override:pending" in your PR
  • Add the corresponding label based on the review deadline category (when this override must be checked):
    • WHEN BACKPORT 0.29 ·
    • BEFORE MIGRATION 0.31 ·
    • WAITING FOR PR UPSTREAM ·
    • OTHER
  • Add the link to the related Decidim issue or PR (if exist).

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Extra information

@BarbaraOliveira13 BarbaraOliveira13 changed the title backport banner color of CTA newsletters from black to white ##954 fix: newsletter-banner-color May 11, 2026
@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review May 12, 2026 10:20
Copy link
Copy Markdown
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants