fix: newsletter-banner-color#985
Open
BarbaraOliveira13 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
Backport of the newsletter banner color fix from #954 (branch
alt/cd44) torc-4.0.0.Instead of hardcoding the white color, this PR introduces an environment variable
DECIDIM_CUSTOM_NEWSLETTER_BAR_COLORto configure the banner color per client. If the variable is not set, the default Decidim behavior is preserved — no other clients are impacted.The variable must be set to
#FFFFFFfor Loire Atlantique/cd44 after merging.Also, fix Accessibilty test
spec/system/proposals_index_spec.rb[1:1:2:2]by override .rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/decidim-a664bb881843/decidim-core/app/cells/decidim/data_consent/category.erb app/cells/decidim/data_consent/category.erb and changingh3 -> spanLine 16Testing
DECIDIM_CUSTOM_NEWSLETTER_BAR_COLOR="#FFFFFF"in your.envor when you're run 'DECIDIM_CUSTOM_NEWSLETTER_BAR_COLOR=#FFFFFF bundle exec rails s'📌 Related Issues
Tasks
🛠️ If your PR introduces or updates an Override
📷 Screenshots
Please add screenshots of the changes you're proposing if related to the UI
Extra information