Fix: send updated appearance back to self after outfit change#174
Open
KanikaBreed wants to merge 1 commit into
Open
Fix: send updated appearance back to self after outfit change#174KanikaBreed wants to merge 1 commit into
KanikaBreed wants to merge 1 commit into
Conversation
When a user changes outfit, the server was broadcasting the new AvatarAppearance to all other nearby clients but not back to the avatar themselves. The viewer keeps a cached copy (mLastProcessedAppearance) of the last AvatarAppearance it received from the server, which was only set at region entry and never updated on subsequent outfit changes. resetSkeleton() replays mLastProcessedAppearance to rebuild the avatar, so it was reverting textures to whatever outfit was worn at region entry. Fix: call SendAppearanceToAgentNF(sp) on self inside SendAppearance() so that mLastProcessedAppearance stays current after every outfit change, matching the existing behaviour already present at region entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue with Firestorm "Reset Skeleton"
When a user changes outfit, the server was broadcasting the new AvatarAppearance to all other nearby clients but not back to the avatar themselves. The viewer keeps a cached copy (mLastProcessedAppearance) of the last AvatarAppearance it received from the server, which was only set at region entry and never updated on subsequent outfit changes.
Firestorm resetSkeleton() replays mLastProcessedAppearance to rebuild the avatar, so it was reverting textures to whatever outfit was worn at region entry.
Fix: call SendAppearanceToAgentNF(sp) on self inside SendAppearance() so that mLastProcessedAppearance stays current after every outfit change, matching the existing behaviour already present at region entry.